build(deps): bump filippo.io/edwards25519 from 1.1.0 to 1.1.1#1
Open
dependabot[bot] wants to merge 2 commits into
Open
build(deps): bump filippo.io/edwards25519 from 1.1.0 to 1.1.1#1dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Decouple the RSA private key used for `caching_sha2_password` authentication from the TLS configuration by accepting it as a separate parameter. Without this PR, the RSA key is extracted from `tlsConfig.Certificates[0]`. This coupling causes issues when using GetCertificate for dynamic certificate loading (e.g., certificate rotation, or serving different certs per connection): - Go's TLS only calls GetCertificate when Certificates is empty OR the client sends SNI - MySQL clients don't send SNI during the TLS handshake - Therefore, if Certificates was populated (to provide the RSA key), the server would serve that certificate instead of calling GetCertificate This is particularly problematic when the TLS certificate uses ECDSA (common with modern CAs like Let's Encrypt and ZeroSSL) but RSA is still needed for the `caching_sha2_password` authentication flow over non-TLS connections. To fix this, we pass the RSA private key directly to `NewServerWithAuth`. It allows users to: - Use `GetCertificate` for TLS without populating `Certificates` - Use ECDSA certificates for TLS while still supporting `caching_sha2_password` non-TLS connections - Rotate TLS certificates dynamically without affecting authentication Note: I can add a new constructor if you don't want to break the API on existing ones.
Bumps [filippo.io/edwards25519](https://github.com/FiloSottile/edwards25519) from 1.1.0 to 1.1.1. - [Commits](FiloSottile/edwards25519@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: filippo.io/edwards25519 dependency-version: 1.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ramnes
force-pushed
the
master
branch
2 times, most recently
from
19f15e2 to
afb116e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps filippo.io/edwards25519 from 1.1.0 to 1.1.1.
Commits
d1c650aextra: initialize receiver in MultiScalarMultYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.