fix(session): survive OSC 8 hyperlink capacity exhaustion#326
Merged
Conversation
Issue: terminal session dies when Codex emits too many OSC 8 hyperlinks. ghostty-vt starts with 4 hyperlinks per page; scroll operations that copy hyperlinked rows to full pages return HyperlinkSetOutOfMemory, which escaped through processOutput() and marked the session dead. Solution: catch HyperlinkSetOutOfMemory, HyperlinkSetNeedsRehash, and HyperlinkMapOutOfMemory inside processOutput() and log a warning instead of propagating them. Affected cells lose their hyperlink, but the session keeps running. ghostty-vt already uses this strategy in Terminal.print for the same class of failure.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca0c988de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rors Address review: nextSlice drops the unprocessed tail of the current PTY read when a hyperlink capacity error occurs mid-buffer. Switch to next(byte) so only the failing byte's side effect is lost; bytes after the failure point are still dispatched to the terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HyperlinkSetOutOfMemory. That error escaped throughstream.nextSlice()intoprocessOutput(), which treated it as unrecoverable and killed the session.HyperlinkSetOutOfMemory,HyperlinkSetNeedsRehash, andHyperlinkMapOutOfMemoryinsideprocessOutput()and logs a warning instead. Affected cells lose their hyperlink, but the session keeps running. ghostty-vt already uses this exact strategy insideTerminal.printfor the same failure mode.Test plan
WARNrather than causingevent=session_failed.