Skip to content

Miriah add users#2

Open
Soypete wants to merge 4 commits into
mainfrom
miriah-add-users
Open

Miriah add users#2
Soypete wants to merge 4 commits into
mainfrom
miriah-add-users

Conversation

@Soypete

@Soypete Soypete commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Soypete added 3 commits June 27, 2024 19:13
Signed-off-by: soypete <petersonmiriah@gmail.com>
Signed-off-by: soypete <petersonmiriah@gmail.com>
@Soypete Soypete force-pushed the miriah-add-users branch from cb6a3bd to d51966b Compare June 28, 2024 01:13
// @gotags: fake:"{jobtitle}"
optional string job_title = 17 [json_name = "job_title"];
// @gotags: fake:"skip"
optional string org_id = 18 [json_name = "org_id"];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a User can only be part of one org?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the use case for more than one org at this point in time. I am sure we should care about at some point

// @gotags: fake:"skip"
optional string org_id = 18 [json_name = "org_id"];
// @gotags: fake:"skip"
optional string meetup_id = 19 [json_name = "meetup_id"];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the ID for an imported user?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

// @gotags: fake:"skip"
repeated string group_id = 20 [json_name = "group_id"];
// @gotags: fake:"{state}"
optional string state = 21 [json_name = "state"];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an enum. . .

Signed-off-by: soypete <petersonmiriah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants