fix(super-threads): show agent questions instead of raw ask_user JSON#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the agent called its
ask_usertool, the thread's action log and the task card's live line showed the literal tool call —Ask_user({"question":"What would you like to name the file…"})— right above the interactive prompt. Those surfaces now read Asked — {question} with a question icon, and once answered, the row pairs the question with the user's answer in the task history.The fix is two-layer because action rows are persisted and replayed via snapshots: the server now decodes
ask_usertool events with the question text as the action arg (readable placeholder fallback — never the args JSON), and the frontend special-cases both newAskrows and legacy persistedAsk_userrows (parsing the stored JSON defensively, never throwing), so pre-fix history renders clean too. While a question is open the row shows no spinner — the "needs your input" prompt is the waiting affordance, and an unanswered question no longer spins forever in a terminal task's history.Closes the last display path of the no-raw-JSON guarantee from
docs/brainstorms/2026-06-08-interactive-agent-questions-requirements.md(R9); plan:docs/plans/2026-06-10-001-fix-ask-user-action-row-rendering-plan.md.Test plan
go test ./...,vitest run(80/80),tsc -b --noEmit,npm run lintall clean.Post-Deploy Monitoring & Validation
Display-only change — no schema, API, or agent-runtime behavior touched.
Ask_user({...})text renders.Ask_user({text visible in a thread, or a blank "Asked —" row.