Feat/interactive agent questions

[clintberry]

What & why

Agent questions could reach the user as a raw tool-call string in the thread, e.g. Ask_user({"question":"What file would you like me to create?"}). That's the structured question path failing — the extension_ui_request event never fires, so the model's narrated call posts as plain text. Two gaps stacked: even on the happy path the question rendered as bare text with no input affordance, and on the failure path it showed raw JSON.

This makes agent questions interactive typed prompts (text / pick-one buttons / yes-no, with a free-text "Other" fallback) and guarantees a question is never shown as raw JSON. Scoped entirely to the Pi harness — no work on the legacy claude executor (slated for removal).

Origin: requirements · plan

How it works

• Typed prompts (U1–U4): ask_user takes an optional kind + options; the extension feature-detects ctx.ui.select/confirm and falls back to input-with-options when absent. kind+options flow through the decoder, persist on tasks (migration 012 — so a reconnect/snapshot reconstructs the prompt), ride the task_awaiting_input payload, and render as buttons / yes-no in the thread drawer. Answers route back through the existing steer → extension_ui_response path.
• No-JSON guarantee (U5–U6):
  • A failed extension install is now loud — error-level log + a user-facing notice that agents can't ask questions (was a silent return nil). Provisioning stays non-fatal.
  • A backstop in the Pi reply-finalize path rewrites a narrated ask_user({...}) into the plain question before persist/broadcast/post, preserving surrounding prose and degrading a truncated call to a readable floor — never a JSON fragment.

Scope notes / deviations from the plan

• Added migration 012 (pending_question_kind TEXT, pending_question_options TEXT[], both defaulted) — additive/backward-compatible. The plan assumed no persistence change, but without it a snapshot refetch would drop the buttons mid-question.
• No Vitest runner wired — followed the repo's existing convention (Vitest-style specs excluded from tsc, type-checked via tsc --noEmit until a runner lands; see tsconfig.app.json). The reducer spec runs the moment a runner is added.
• Rich choices are Pi-path only by design; the legacy harness only ever gets the no-JSON floor.

Testing

• Backend: go build / go vet / go test ./... all green (full DB-backed suite). New tests: decoder options, the agent-runs reducer (incl. snapshot preservation), and the backstop (AE3/AE4 + passthrough negatives).
• Frontend: npm run build + tsc + eslint clean.
• Not yet verified live (no Pi runtime available locally): the real ctx.ui.select/confirm request shape and the exact value Pi expects for a confirm answer. The runtime feature-detection + "yes"/"no" text answer ships either way; worth a smoke-test in a real session before merge.

🤖 Generated with Claude Code