message-format: merge runtime + compiler into message-format#17
Open
Georgiy-Tugai wants to merge 2 commits into
Open
message-format: merge runtime + compiler into message-format#17Georgiy-Tugai wants to merge 2 commits into
Georgiy-Tugai wants to merge 2 commits into
Conversation
Georgiy-Tugai
force-pushed
the
merge-runtime-compiler
branch
2 times, most recently
from
a23d69e to
1bb28e1
Compare
waywardmonkeys
approved these changes
Jun 5, 2026
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
I'm okay with it if you are. Think we definitely need a use pass afterwards.
| fn parse_input_declared_source_name( | ||
| source: &str, | ||
| expr: &crate::syntax::ast::ExpressionNode<'_>, | ||
| expr: &crate::compiler::syntax::ast::ExpressionNode<'_>, |
Contributor
There was a problem hiding this comment.
Definitely makes me think we should do a follow up pass to shorten this stuff up with a use crate::compiler::syntax::ast and then referencing as ast::ExpressionNode or something.
Move message-format-runtime into message_format::runtime and message-format-compiler into message_format::compiler (behind the existing `compile` feature gate). Delete the old crate directories and remove them from the workspace. Consolidate all dependencies into message-format/Cargo.toml with optional dep groups for icu4x and compile features. Update all internal consumers (resource crates, CLI, LSP, wind_tunnel, conformance) to depend on message-format with appropriate features instead of the individual crates. Fix all import paths repo-wide. Update CI env vars: remove deleted crates from RUST_MIN_VER_PKGS and RUST_NO_STD_PKGS, remove compile from FEATURES_DEPENDING_ON_STD.
Georgiy-Tugai
force-pushed
the
merge-runtime-compiler
branch
from
1bb28e1 to
9b5c2b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
message-format-runtimeintomessage_format::runtimeandmessage-format-compilerintomessage_format::compiler(behind theexisting
compilefeature gate). Delete the old crate directories andremove them from the workspace.
Consolidate all dependencies into
message-format/Cargo.tomlwithoptional dep groups for
icu4xandcompilefeatures.Update all internal consumers (resource crates, CLI, LSP, wind_tunnel,
conformance) to depend on
message-formatwith appropriate featuresinstead of the individual crates. Fix all import paths repo-wide.
Update CI env vars: remove deleted crates from
RUST_MIN_VER_PKGSandRUST_NO_STD_PKGS, remove compile fromFEATURES_DEPENDING_ON_STD.