Support imaging_skia GPU with wgpu 29 Metal#68
Open
waywardmonkeys wants to merge 1 commit into
Open
Conversation
wgpu 29 removed the API that let imaging_skia get the raw Metal command queue from a wgpu::Queue. Skia's Ganesh Metal backend still needs an MTLCommandQueue when creating its DirectContext, so create and retain a Skia-owned Metal command queue from the shared Metal device instead of trying to borrow wgpu's queue. This keeps the GPU backend working on wgpu 29 without changing the public imaging_skia API. wgpu is expected to regain the relevant raw queue access in wgpu 30, so this can be revisited when that API is available again. Because Skia now submits work through a separate Metal queue, synchronize the shared texture path more conservatively: flush Metal surfaces with SyncCpu::Yes and wait for the wgpu texture initialization pass before handing textures to Skia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
wgpu 29 removed the API imaging_skia used to get the raw Metal command queue from a wgpu::Queue. Skia's Ganesh Metal backend still needs an MTLCommandQueue when creating its DirectContext, so this branch creates one from the shared Metal device and keeps it alive with the Skia backend.
The raw queue access is expected to return in wgpu 30, so this is intended as a narrow compatibility bridge for wgpu 29 rather than a permanent API direction.
Testing