imaging_vello_hybrid: support blurred rounded rects and filters#45
Open
jrmoulton wants to merge 1 commit into
Open
imaging_vello_hybrid: support blurred rounded rects and filters#45jrmoulton wants to merge 1 commit into
jrmoulton wants to merge 1 commit into
Conversation
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
You should enable the snapshot tests for gm_group_blur_filter and gm_group_drop_shadow ideally.
| Error::UnsupportedImageBrush => { | ||
| TextureRendererError::Unsupported(RenderUnsupportedError::ImageBrush) | ||
| } | ||
| Error::UnsupportedFilter => { |
Contributor
There was a problem hiding this comment.
This should still be used for filters with more than one primitive which aren't supported.
| Error::InvalidScene(error) => { | ||
| TextureRendererError::Content(RenderContentError::InvalidScene(error)) | ||
| } | ||
| Error::UnsupportedImageBrush => { |
Contributor
There was a problem hiding this comment.
Why remove this? The error type still exists...
| } | ||
| if let Some(output) = last { | ||
| graph.set_output(output); | ||
| } |
Contributor
There was a problem hiding this comment.
You dropped some logic here that was in the vello_cpu adapter code...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.