imaging_skia: use native Skia layers for masks#11
Open
jrmoulton wants to merge 1 commit into
Open
Conversation
jrmoulton
force-pushed
the
push-lpoznrtnsyxr
branch
from
693ec83 to
a06a447
Compare
waywardmonkeys
requested changes
Apr 1, 2026
| self.mask_cache.borrow_mut().clear(); | ||
| } | ||
| /// No-op retained for API compatibility after native Skia masking removed realized mask caches. | ||
| pub fn clear_cached_masks(&mut self) {} |
Contributor
There was a problem hiding this comment.
No need for this no-op compatibility thing. And can remove the associated tests as well ...
Contributor
|
Also please update the screenshot test here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performance is improved.
The snapshot tests for luminance masks differ by 5000 pixels but visually I can't see the difference. I'm inclined to think that the native skia rendering is more likely to be correct