⚡ Bolt: [performance improvement] Hoist invariant polyphony properties out of trigger loop#800
⚡ Bolt: [performance improvement] Hoist invariant polyphony properties out of trigger loop#800ford442 wants to merge 2 commits into
Conversation
…s out of trigger loop Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Extracted static note parser and midi lookup outside the inner retrigger loops in createPlaySynth. Also hoisted the nested triggerVoice function out of the polyphonic notes.forEach in useAudioEngine stretch mode.
🎯 Why: Redundant array parsing, function declarations, and midi lookups inside tightly-grouped high-frequency iterators (such as thick chords or rapid retrigger stutter effects) cause unnecessary Main thread CPU usage and GC (Garbage Collection) pressure.
📊 Impact: Reduces redundant calculations inside audio Playback hooks during granular slicing operations, thick unison, and retriggers.
🔬 Measurement: Verify stable Main Thread performance while mashing keys playing polyphonic chords.
PR created automatically by Jules for task 1976699326403304213 started by @ford442