Skip to content

feat: Formant Envelope Follower#799

Merged
ford442 merged 2 commits into
mainfrom
feat/formant-envelope-follower-714986474099753320
Jun 22, 2026
Merged

feat: Formant Envelope Follower#799
ford442 merged 2 commits into
mainfrom
feat/formant-envelope-follower-714986474099753320

Conversation

@ford442

@ford442 ford442 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Added an Envelope Follower that modulates the Formant Shift amount dynamically based on the vocal amplitude envelope. Implemented via a native Web Audio sidechain follower circuit (WaveShaperNode -> BiquadFilterNode -> GainNode) within FormantShifter.ts. Exposed formantEnvFollower parameter globally and per-step to the UI via SamplerPanel and NoteSelector. Wired it down through useAudioEngine.ts and SingingVoice.ts to dynamically modulate the formant detune amount based on the vocal amplitude envelope.


PR created automatically by Jules for task 714986474099753320 started by @ford442

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ford442, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 26 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f2ba50ce-41b5-4449-8182-a082209e05e3

📥 Commits

Reviewing files that changed from the base of the PR and between 54b63c3 and 85cb1c7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (15)
  • agent_plan.md
  • package.json
  • patch_brace_correct.py
  • patch_brace_final.py
  • patch_mock6.py
  • src/__tests__/SamplerPanel.perf.test.tsx
  • src/components/NoteSelector.tsx
  • src/components/SamplerPanel.tsx
  • src/components/appParts/ContextMenuNode.tsx
  • src/engines/SingingVoice.ts
  • src/engines/rubberband/FormantShifter.ts
  • src/hooks/audioEngine/audioPlayback.ts
  • src/hooks/useAppState.tsx
  • src/hooks/useAudioEngine.ts
  • src/types.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/formant-envelope-follower-714986474099753320

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ford442 ford442 marked this pull request as ready for review June 22, 2026 19:49
@ford442 ford442 merged commit d9d45b7 into main Jun 22, 2026
0 of 3 checks passed
@ford442 ford442 deleted the feat/formant-envelope-follower-714986474099753320 branch June 22, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant