chore(plan): weekly routine 2026-06-12 + fix .env.production base path

[ford442]

Weekly routine — 2026-06-12 (+ a build-pipeline fix)

Two things in this branch:

1. weekly_plan.md update (Mode: User Idea)

• Mobile-lite render mode (last week's focus) reconciled to Done (PR Weekly plan 2026-06-05 — Mobile/low-end "lite" render mode (User Idea) #251); runtime verify → Backlog.
• Storage save-back + sync (last week's Copilot issue) landed via feat: storage-manager save-back + library sync + surface rating errors #254; issue Storage-manager: save-back + sync + complete shader-rating hookup #252 rating-hookup remnant → Backlog.
• Today's focus: dynamic per-instrument color palettes (extends the colorPalette uniform / PR Fix color-per-note drift, expression LEDs, and add palette switching #148).
• Decoupled Copilot issue filed this run: Media overlay: auto-detect sync + fade/timing controls + resizable panel & progressive PiP #266 (media-overlay auto-detect + fade + resizable panel & progressive PiP).

2. fix(build): make .env.production actually set the Vite base path

Found during a pipeline-hygiene pass. vite.config.ts read process.env.VITE_APP_BASE_PATH, but Vite does not populate process.env from .env files (only import.meta.env, via loadEnv). So the .env.production added earlier this cycle ("so production builds always use /xm-player/ base path") was a no-op for base — a plain npm run build emitted base / and would produce a broken subdirectory deploy, caught only by deploy.py's validate_build_base_path() backstop.

Fix: loadEnv(mode, cwd, 'VITE_') with precedence inline/shell env var → .env[.mode] → /. Verified empirically:

• plain npm run build → now emits /xm-player/ base via .env.production ✅
• build:xm-player (inline env) → still /xm-player/ ✅ (no regression)
• dev mode (no .env.development) → still / ✅ (no regression)

tsc && vite build green; canonical dist audited (correct /xm-player/ asset URLs, no double-prefix, 32 shaders + worklets copied).

https://claude.ai/code/session_01Q6U84mzffZsvu3yZPeo83h

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c128fe96-6561-4615-966f-a698bb54b8b1

📥 Commits

Reviewing files that changed from the base of the PR and between 2419ae0 and 5ff271c.

📒 Files selected for processing (1)

• weekly_plan.md

---

📝 Walkthrough

Walkthrough

weekly_plan.md is updated to shift the active focus from mobile/low-end lite rendering to dynamic per-instrument color palettes. Mobile-lite work is marked completed and documented with recent PR references, while palettes move to in-progress. Runtime verification tasks and outcome summaries are added.

Changes

Project Status and Focus Update

Layer / File(s)

Summary

Planning document status and focus update weekly_plan.md

Today's focus section shifts from mobile/low-end lite to dynamic per-instrument color palettes (palette-LUT + shader indexing). Ideas list marks mobile-lite as completed (PR #251) and moves palettes to in-progress. Done section adds 6/12 items including mobile-lite, storage-sync (PR #254), WebGL2 fallback (PR #258), large-file split (PR #257), and deploy hardening (PR #260/#261). Backlog gains mobile-lite runtime verification checklist. Last run narrative updates to reflect new focus and documents outcomes for completed mobile-lite and storage-sync work plus remaining palette verification tasks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• ford442/mod-player#239: Prior update to weekly_plan.md that originally added the mobile/low-end lite and dynamic per-instrument color palettes roadmap entries that this PR now progresses and completes.

Poem

🐰 The render path grows lean and bright,
With colors drawn from modules' light,
Mobile runs smooth, the lite mode lands—
Each shader now obeys your hands! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/charming-johnson-lpzkfw

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}