Skip to content

Upgrade custom Milkdrop presets and add Aurora/Crystal presets#109

Merged
ford442 merged 1 commit into
mainfrom
cursor/preset-create-upgrade-9107
Jun 19, 2026
Merged

Upgrade custom Milkdrop presets and add Aurora/Crystal presets#109
ford442 merged 1 commit into
mainfrom
cursor/preset-create-upgrade-9107

Conversation

@ford442

@ford442 ford442 commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

This PR brings the custom_milk_fixed/ regression corpus up to projectM WASM standards and adds two new presets.

Upgraded presets (runtime blockers fixed)

Preset group Problem Fix
milk001milk003 Full-scene per_pixel HLSL (ret = float3(...)) — not rendered on WASM Ported visuals to comp_ shaders with shader_body wrappers
milk004milk007 Used unsupported draw_shape() / loop() APIs Replaced with shapecode_0 + num_inst instancing
fractal_echo_* Missing shader_body, reserved names (ang/rad), bad wave/shape keys Wrapped shaders, renamed builtins, fixed key prefixes
milk012milk014 shapecode_0_per_frameN keys ignored by parser Renamed to shape_0_per_frameN

New presets

  • milk017.milk — Aurora Borealis: bass-reactive sine-field warp, spectrum wave curtain, additive aurora composite
  • milk018.milk — Crystal Lattice: hexagonal lattice warp (variant of the milk014 brief), prismatic comp, rotating hex emblem

Validation

All 25/25 presets in custom_milk_fixed/ now pass scripts/kimi_validate_preset.sh (parse + HLSL→GLSL transpile):

PROJECTM_TEST_CUSTOM_MILK_FIXED=1 scripts/test_presets.sh custom_milk_fixed cmake-build-verify
# => 91/91 tests passed

html/custom_presets_manifest.json was regenerated (node scripts/generate_custom_preset_manifest.mjs).

Notes

  • Screenshot/WASM visual capture was not re-run in this environment (no prebuilt WASM bundle). Transpile validation is clean; recommend a follow-up capture_custom_milk_screenshots.mjs run to refresh golden frames.
  • Key pitfall discovered during upgrade: ang and rad are reserved shader aliases — using them as variable names produces invalid HLSL after preprocessing.
Open in Web Open in Cursor 

- Port milk001-milk003 from broken per_pixel HLSL to warp/comp shaders
- Replace unsupported draw_shape/loop in milk004-milk007 with shapecode num_inst
- Fix fractal_echo presets: shader_body wrappers, ang/rad builtin collisions,
  wave/shape key prefixes, and invalid shader references
- Fix milk012-milk014 shape_0_per_frame key prefix for projectM parser
- Add milk017 (Aurora Borealis) and milk018 (Crystal Lattice) WASM presets
- Regenerate html/custom_presets_manifest.json (25 presets, all transpile-clean)

Co-authored-by: Noah Cohn <noahc42@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ford442, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 124470b0-f430-4569-952b-ed4b1f197db5

📥 Commits

Reviewing files that changed from the base of the PR and between 8a070c4 and 7765989.

📒 Files selected for processing (20)
  • custom_milk_fixed/custom_fractal_echo_copilot_gpt54.milk
  • custom_milk_fixed/custom_fractal_echo_gemini.milk
  • custom_milk_fixed/custom_fractal_echo_granite.milk
  • custom_milk_fixed/fractal_echo_gptoss120b.milk
  • custom_milk_fixed/fractal_echo_kimi.milk
  • custom_milk_fixed/fractal_tunnel_grok.milk
  • custom_milk_fixed/milk001.milk
  • custom_milk_fixed/milk002.milk
  • custom_milk_fixed/milk003.milk
  • custom_milk_fixed/milk004.milk
  • custom_milk_fixed/milk005.milk
  • custom_milk_fixed/milk006.milk
  • custom_milk_fixed/milk007.milk
  • custom_milk_fixed/milk012.milk
  • custom_milk_fixed/milk013.milk
  • custom_milk_fixed/milk014.milk
  • custom_milk_fixed/milk017.milk
  • custom_milk_fixed/milk018.milk
  • html/custom_presets_manifest.json
  • presets/agent_manifest.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/preset-create-upgrade-9107

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ford442 ford442 marked this pull request as ready for review June 19, 2026 05:32
@ford442 ford442 merged commit 667da33 into main Jun 19, 2026
30 of 44 checks passed
@ford442 ford442 deleted the cursor/preset-create-upgrade-9107 branch June 19, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants