Upgrade custom Milkdrop presets and add Aurora/Crystal presets#109
Conversation
- Port milk001-milk003 from broken per_pixel HLSL to warp/comp shaders - Replace unsupported draw_shape/loop in milk004-milk007 with shapecode num_inst - Fix fractal_echo presets: shader_body wrappers, ang/rad builtin collisions, wave/shape key prefixes, and invalid shader references - Fix milk012-milk014 shape_0_per_frame key prefix for projectM parser - Add milk017 (Aurora Borealis) and milk018 (Crystal Lattice) WASM presets - Regenerate html/custom_presets_manifest.json (25 presets, all transpile-clean) Co-authored-by: Noah Cohn <noahc42@gmail.com>
|
Warning Review limit reached
More reviews will be available in 19 minutes and 11 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR brings the
custom_milk_fixed/regression corpus up to projectM WASM standards and adds two new presets.Upgraded presets (runtime blockers fixed)
milk001–milk003per_pixelHLSL (ret = float3(...)) — not rendered on WASMcomp_shaders withshader_bodywrappersmilk004–milk007draw_shape()/loop()APIsshapecode_0+num_instinstancingfractal_echo_*shader_body, reserved names (ang/rad), bad wave/shape keysmilk012–milk014shapecode_0_per_frameNkeys ignored by parsershape_0_per_frameNNew presets
milk017.milk— Aurora Borealis: bass-reactive sine-field warp, spectrum wave curtain, additive aurora compositemilk018.milk— Crystal Lattice: hexagonal lattice warp (variant of the milk014 brief), prismatic comp, rotating hex emblemValidation
All 25/25 presets in
custom_milk_fixed/now passscripts/kimi_validate_preset.sh(parse + HLSL→GLSL transpile):PROJECTM_TEST_CUSTOM_MILK_FIXED=1 scripts/test_presets.sh custom_milk_fixed cmake-build-verify # => 91/91 tests passedhtml/custom_presets_manifest.jsonwas regenerated (node scripts/generate_custom_preset_manifest.mjs).Notes
capture_custom_milk_screenshots.mjsrun to refresh golden frames.angandradare reserved shader aliases — using them as variable names produces invalid HLSL after preprocessing.