Skip to content

[US-91] feat: CommandConfig Contract & Parser Refactoring #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rucka merged 62 commits into from
Feb 1, 2026
Merged

[US-91] feat: CommandConfig Contract & Parser Refactoring #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
0903bb9
[#91] feat: define CommandConfig discriminated union types
rucka Dec 20, 2025
f5b6c5e
update prompt tools
rucka Dec 20, 2025
cf540a1
feat(commands): implement handlers & module objects (T-2)
rucka Dec 20, 2025
549997a
feat(commands): generic dispatcher + unified source detection (T-6)
rucka Dec 20, 2025
6dc5d90
feat(commands): config builders + shared helpers (T-7)
rucka Dec 20, 2025
1be0242
feat(cli): integrate parsers+dispatcher (T-8)
rucka Dec 20, 2025
ce8b4b1
refactor: remove unused command objects from index.ts
rucka Dec 20, 2025
1c04983
refactor: remove unused command objects from index.ts
rucka Dec 20, 2025
ecbdace
test(cli): mark legacy tests for T-9 conversion
rucka Dec 20, 2025
877d7b3
test(cli): add parser→dispatcher integration tests (T-9a)
rucka Dec 20, 2025
714d053
docs(cli): document parser→dispatcher architecture (T-9/T-10)
rucka Dec 20, 2025
c1c1f54
refactor(tests): riorganizza test in command folders (T-9)
rucka Dec 21, 2025
656c341
refactor(tests): elimina test legacy duplicati
rucka Dec 21, 2025
7a26de5
refactor(tests): rimuovi duplicati integration.test
rucka Dec 21, 2025
06a37b4
refactor(cli): dependency injection per test e2e
rucka Dec 21, 2025
246fdc8
test(cli): infrastruttura test e2e + CliDependencies required
rucka Dec 21, 2025
adfa07f
test(cli): +13 test e2e (29 totali, 13 pass)
rucka Dec 21, 2025
619244b
feat(cli): implementa handler install/update + fix TypeScript
rucka Dec 21, 2025
111e695
fix: gestione kb global option + merge global/cmd options
rucka Dec 21, 2025
70efc64
feat: implementa package/validate-config handlers
rucka Dec 21, 2025
eadf30b
refactor: executePackage dependency injection, completa handler package
rucka Dec 21, 2025
c91942a
test: aggiungi e2e update-link (validate/dry-run)
rucka Dec 21, 2025
4aa2b83
fix: validate-config handler + parseAsync in runCli (partial fix - 1/…
rucka Dec 21, 2025
560bfde
fix: fresh Command instance ogni runCli - passa tutti validate-config…
rucka Dec 21, 2025
4a90857
fix: Commander opts() parsing + update-link/package test pass
rucka Dec 21, 2025
2cc60a2
feat: FileSystemService zip/unzip + package tests pass 4/4
rucka Dec 21, 2025
76eea37
refactor: consolida test ZIP in in-memory-fs.test.ts (52/52 pass)
rucka Dec 21, 2025
3730448
feat(#91): kb-validate command - parser/handler/tests (3/3 e2e pass)
rucka Dec 21, 2025
0710dc6
test(#91): kb-validate unit tests - parser/handler (8/8 pass)
rucka Dec 21, 2025
4e6e1c4
test(#90/#91): edge case coverage - empty source, non-existent path, …
rucka Dec 21, 2025
ded9fd1
refactor(#91): extract helpers from createPackageZip (max 50 lines)
rucka Dec 21, 2025
0d8b7b6
docs(#91): add comprehensive JSDoc to parsers, handlers, registry (T-10)
rucka Dec 21, 2025
bfe2986
fix(#91): add mkdirSync to FileSystemService interface+impl
rucka Dec 21, 2025
7ac2f8a
fix: zip-creator tests use fsService, skip integration tests
rucka Dec 21, 2025
e31e21b
docs: update test status - 100% pass rate achieved
rucka Dec 21, 2025
6b90723
chore: format whitespace (prettier)
rucka Dec 21, 2025
8e48dc9
refactor: kb-validate handler - remove legacy dependency
rucka Dec 21, 2025
fbcc163
refactor: update-link handler - implement with legacy call
rucka Dec 21, 2025
05dc7d1
chore: rimuovi test skipped (codice morto)
rucka Dec 21, 2025
5398a89
test: rewrite skipped tests as unit with mocks
rucka Dec 21, 2025
359426c
refactor: move package/update-link logic to handlers
rucka Dec 21, 2025
cf5185e
test: fix handler tests after legacy file deletion
rucka Dec 21, 2025
74ba6a2
HttpClientService abstraction + test cleanup
rucka Dec 21, 2025
2edc8dd
re-enable 5 skipped tests + fix path handling in doCopyAndUpdateLinks
rucka Dec 22, 2025
1db7edc
chore: prettier formatting
rucka Dec 22, 2025
5628422
Update cli.e2e.test.ts
rucka Dec 22, 2025
1b3bb42
feat(cli): refactor update/update-link handlers with backup logic and…
rucka Jan 24, 2026
acce9f4
chore(cli): remove debug logging in update command
rucka Jan 24, 2026
2c51478
refactor(cli): delegate generic logic to content-ops and clean up com…
rucka Jan 24, 2026
21ce33f
refactor(content-ops): move detectLinkStyle to LinkProcessor and add …
rucka Jan 24, 2026
132f4f1
refactor(cli): reorganize utility modules and consolidate validation
rucka Jan 24, 2026
2983945
refactor(cli): consolidate test helpers and fixtures
rucka Jan 24, 2026
b4c5657
refactor(cli): create centralized registry module and unify configura…
rucka Jan 24, 2026
aa26c38
refactor(registry): remove types-only file and co-locate interfaces
rucka Jan 24, 2026
8371430
refactor(cli): modularize architecture and modernize test suite (elim…
rucka Jan 24, 2026
fecfeac
refactor(pair-cli): redistribute configuration and discovery logic in…
rucka Jan 24, 2026
7f42edb
refactor(pair-cli): overhaul command utilities and bootstrap architec…
rucka Jan 24, 2026
7d32f9f
Refactor: CLI lifecycle, registry backup migration, and path aliases …
rucka Jan 24, 2026
88f4db7
Feat: Add support for disjoint KB installation and command targeting
rucka Jan 24, 2026
8a6d755
chore(pair-cli): add --log-level alias; migrate docs; add smoke-test …
rucka Feb 1, 2026
e71fb53
test: comprehensive testing for CommandConfig, parsers, handlers (T-9…
rucka Feb 1, 2026
8c99d75
docs: JSDoc for bootstrap guard clause and CLI architecture in README…
rucka Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/agents/product-engineer.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
description: Product Engineer mode for AI-assisted development. Creates tasks, implements features, and manages development lifecycle following established how-to guides.
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
tools: ['vscode', 'execute', 'read', 'edit', 'search', 'web', 'gitkraken/*', 'github/*', 'agent', 'todo']

---

Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/breakdown-stories.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Breakdown epics into detailed user stories with clear acceptance criteria
agent: product-engineer
tools: ['edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Breakdown Stories
Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/code-review.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Perform comprehensive code review following quality guidelines and best practices
agent: staff-engineer
tools: ['search/codebase', 'edit/editFiles', 'search', 'read/problems', 'search/changes', 'execute/runTests', 'github/*']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Code Review
Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/complete-bootstrap-checklist.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Complete the bootstrap checklist to set up project foundation and structure
agent: staff-engineer
tools: ['edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*', 'runCommands']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Complete Bootstrap Checklist
Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/create-tasks.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Create specific, actionable development tasks from refined user stories
agent: product-engineer
tools: ['edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Create Tasks
Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/define-bounded-contexts.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Define bounded contexts to establish technical architecture boundaries based on business subdomains
agent: staff-engineer
tools: ['edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Define Bounded Contexts
Expand Down
11 changes: 1 addition & 10 deletions .github/prompts/implement-task.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
---
description: Implement a specific task by following technical guidelines and producing working, tested code
agent: product-engineer
tools:[ 'edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*',
'edit/editFiles',
'search/codebase',
'search',
'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand',
'github/*',
'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection',
'execute/runTests',
'read/problems',
]
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Implement Task
Expand Down
2 changes: 1 addition & 1 deletion .github/prompts/refine-story.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
description: Refine user stories with detailed acceptance criteria and technical specifications
agent: product-engineer
tools: ['edit/editFiles', 'search/codebase', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'github/*']
tools: ['edit', 'execute/runNotebookCell', 'read/getNotebookSummary', 'read/readNotebookCellOutput', 'search', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/newWorkspace', 'vscode/runCommand', 'execute/getTerminalOutput', 'execute/runInTerminal', 'read/terminalLastCommand', 'read/terminalSelection', 'execute/createAndRunTask', 'execute/getTaskOutput', 'execute/runTask', 'gitkraken/*', 'github/*', 'search/usages', 'vscode/vscodeAPI', 'read/problems', 'search/changes', 'execute/testFailure', 'vscode/openSimpleBrowser', 'web/fetch', 'web/githubRepo', 'vscode/extensions', 'todo', 'agent', 'execute/runTests']
---

# Refine Story
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ release/
!scripts/workflows/release
.tmp/
.benchmark-tmp/
.kilocode/
docs/performance/benchmark-report.json
Loading