Skip to content

chore(unit-tests): Add tests for TransactionHelper #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfilippov-epam merged 3 commits into from
Jun 16, 2026
Merged

chore(unit-tests): Add tests for TransactionHelper #263

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84fbce3
[chore] [mod-dcb] unit tests
aitestmate-epam May 23, 2026
16681f8
Merge branch 'master' into unit_tests_org_folio_dcb_integration_kafka…
pfilippov-epam Jun 16, 2026
247a0e7
chore(unit-tests): Update tests to follow codestyle
pfilippov-epam Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 154 additions & 0 deletions src/test/java/org/folio/dcb/integration/kafka/TransactionHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import java.nio.charset.StandardCharsets;
import java.util.Map;
import org.folio.dcb.integration.kafka.model.EventData;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension;
Expand Down Expand Up @@ -72,4 +73,157 @@

assertThat(result).hasSize(1).containsExactly(headerValue);
}

@Test
void parseLoanEventShouldMapCheckOutAction() {
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"action": "checkedout"
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull();
assertThat(result.getType()).isEqualTo(EventData.EventType.CHECK_OUT);
}

@Test
void parseLoanEventShouldMapCheckInAction() {
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"action": "checkedin"
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull();
assertThat(result.getType()).isEqualTo(EventData.EventType.CHECK_IN);
}

@Test
void parseLoanEventShouldReturnNullTypeForUnknownAction() {
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"action": "other"
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull();
assertThat(result.getType()).isNull();
}

@Test
void parseLoanEventShouldDefaultIsDcbToTrueWhenMissing() {

Check warning on line 141 in src/test/java/org/folio/dcb/integration/kafka/TransactionHelperTest.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one. 


See more on https://sonarcloud.io/project/issues?id=org.folio%3Amod-dcb&issues=AZ7Q_WecjJoRka71o0CR&open=AZ7Q_WecjJoRka71o0CR&pullRequest=263
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s"
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull()
.extracting(EventData::isDcb)
.isEqualTo(true);
}

@Test
void parseLoanEventShouldPreserveIsDcbWhenTrue() {
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"isDcb": true
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull()
.extracting(EventData::isDcb)
.isEqualTo(true);
}

@Test
void parseLoanEventShouldPreserveIsDcbWhenFalse() {
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"isDcb": false
}
}
}
""".formatted(itemId);

var result = TransactionHelper.parseLoanEvent(payload);

assertThat(result).isNotNull()
.extracting(EventData::isDcb)
.isEqualTo(false);
}

@Test
void parseLoanEventShouldPopulateLoanStatusWhenPresent() {
// TestMate-bcbe206fc559de7d897da32b27a7e5ab
var itemId = "8db107f5-12aa-479f-9c07-39e7c9cf2e4d";
var expectedStatus = "Open - Checked out";
var payload = """
{
"type": "UPDATED",
"data": {
"new": {
"itemId": "%s",
"status": {
"name": "%s"
}
}
}
}
""".formatted(itemId, expectedStatus);

var result = TransactionHelper.parseLoanEvent(payload);
assertThat(result).isNotNull();
assertThat(result.getItemId()).isEqualTo(itemId);
assertThat(result.getLoanStatus()).isEqualTo(expectedStatus);
}
}
Loading