Skip to content

MODBULKOPS-659 - QA fixes#649

Merged
siarhei-charniak merged 3 commits into
masterfrom
MODBULKOPS-659
Jul 6, 2026
Merged

MODBULKOPS-659 - QA fixes#649
siarhei-charniak merged 3 commits into
masterfrom
MODBULKOPS-659

Conversation

@siarhei-charniak

@siarhei-charniak siarhei-charniak commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

MODBULKOPS-659 - QA fixes

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@siarhei-charniak siarhei-charniak self-assigned this Jul 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@siarhei-charniak siarhei-charniak changed the title MODBULKOPS-659 - Fix identifier type in error log MODBULKOPS-659 - QA fixes Jul 6, 2026
@siarhei-charniak siarhei-charniak merged commit 666f256 into master Jul 6, 2026
16 checks passed
@siarhei-charniak siarhei-charniak deleted the MODBULKOPS-659 branch July 6, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants