Skip to content

fix: use trusted publishing for packages#236

Merged
duncanleo merged 1 commit into
mainfrom
codex/fix-package-publish-auth
May 19, 2026
Merged

fix: use trusted publishing for packages#236
duncanleo merged 1 commit into
mainfrom
codex/fix-package-publish-auth

Conversation

@duncanleo
Copy link
Copy Markdown
Member

@duncanleo duncanleo commented May 19, 2026

Summary

  • Remove NPM_TOKEN and NODE_AUTH_TOKEN from the Changesets publish step.
  • Let npm publish use GitHub Actions OIDC/trusted publishing, matching the package publishing approach from the data-overhaul branch.
  • Leave the branch without a changeset so changesets/action@v1 takes its no-changesets path and publishes the already-versioned, unpublished @mrtdown/core and @mrtdown/fs packages.

Root Cause

The merged package publish run reached changeset publish, but npm returned E404 Not Found ... or you do not have permission for both @mrtdown/core@2.0.0-alpha.23 and @mrtdown/fs@2.0.0-alpha.23. The workflow was passing secrets.NPM_TOKEN, so npm attempted token-based publish with a token that does not have publish rights for the @mrtdown scope. The repository already has id-token: write, so the workflow should use npm trusted publishing instead.

Validation

  • npm run check
  • npm run changeset -- status --since origin/main

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@duncanleo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 47 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cde068b6-5aa2-424b-8ef4-9ebfd27d87df

📥 Commits

Reviewing files that changed from the base of the PR and between 5938f92 and 67d8ab7.

📒 Files selected for processing (1)
  • .github/workflows/package-publish.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-package-publish-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9536b14688

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .changeset/bold-balloons-design.md Outdated
@duncanleo duncanleo force-pushed the codex/fix-package-publish-auth branch from 9536b14 to 67d8ab7 Compare May 19, 2026 02:37
@duncanleo duncanleo merged commit bb05a6d into main May 19, 2026
2 checks passed
@duncanleo duncanleo deleted the codex/fix-package-publish-auth branch May 19, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant