guard against searching for VMs with id nil - #315
Merged
Conversation
Collaborator
Author
|
The failing Ruby / test (head) (pull_request) is an issue in the |
evgeni
reviewed
Oct 9, 2025
stejskalleos
force-pushed
the
ls/include_safe_guard
branch
from
October 10, 2025 11:13
b9b0ea2 to
e84a9f4
Compare
stejskalleos
changed the title
stejskalleos
force-pushed
the
ls/include_safe_guard
branch
from
October 10, 2025 11:31
e84a9f4 to
b545484
Compare
evgeni
reviewed
Oct 10, 2025
stejskalleos
force-pushed
the
ls/include_safe_guard
branch
from
October 14, 2025 08:33
b545484 to
2c26809
Compare
Collaborator
Author
|
added |
evgeni
approved these changes
Oct 14, 2025
evgeni
left a comment
evgeni
left a comment
There was a problem hiding this comment.
I think the summary of this PR should be more like:
guard against searching for VMs with id nil
- get_virtual_machine - Raise a NotFound error when id is nil
- Compute::Server - only fetch SCSI and NVMe controllers when id is not nil
other than that: ACK
- get_virtual_machine - Raise a NotFound error when id is nil - Compute::Server - only fetch SCSI and NVMe controllers when id is not nil
stejskalleos
force-pushed
the
ls/include_safe_guard
branch
from
October 14, 2025 10:39
2c26809 to
cba0fa2
Compare
stejskalleos
changed the title
Collaborator
Author
|
PR & commit message updated |
evgeni
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.