Skip to content

Remove deck CSV workflow and simplify CLI#12

Closed
fmolinagomez wants to merge 2 commits into
masterfrom
codex/analyze-entire-codebase-from-scratch-huoqoa
Closed

Remove deck CSV workflow and simplify CLI#12
fmolinagomez wants to merge 2 commits into
masterfrom
codex/analyze-entire-codebase-from-scratch-huoqoa

Conversation

@fmolinagomez

Copy link
Copy Markdown
Owner

Summary

  • drop deck CSV handling from the CLI so cards are always rendered individually from the JSON definition into an output folder
  • update the image processing helpers to work with explicit output directories instead of deck names
  • refresh the README to describe the streamlined command options and generated folder structure

Testing

  • python -m pytest

https://chatgpt.com/codex/tasks/task_e_68e3a37225e0832e8632dd3eccc661f6

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

@lru_cache(maxsize=128)
def _load_full_frame_surface_cached(image_name: str, dpi: int):
size_px = layout.pair_mm_to_pixels((layout.CARD_WIDTH_MM, layout.CARD_HEIGHT_MM), dpi)
resized_image = _load_resized_source_image(image_name, size_px)
if resized_image is None:
return None
buffer = io.BytesIO()
resized_image.save(buffer, format='PNG')
buffer.seek(0)
surface = cairo.ImageSurface.create_from_png(buffer)
return surface

P1 Badge Import io for full-frame image rendering

The _load_full_frame_surface_cached helper now converts images into an in-memory PNG using io.BytesIO, but add_images.py no longer imports the io module. When cards have full_frame_image enabled and --images is passed, the first call to load_full_frame_surface will raise NameError: name 'io' is not defined, preventing full-frame images from rendering. Adding import io at the top of the module fixes the crash.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@fmolinagomez fmolinagomez reopened this Oct 6, 2025
@fmolinagomez fmolinagomez deleted the codex/analyze-entire-codebase-from-scratch-huoqoa branch October 6, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant