using evalRandT and RandT explicitly#35
Merged
Merged
Conversation
guard-who
changed the title
evalRandT and RandT directly
guard-who
changed the title
evalRandT and RandT directlyevalRandT and RandT explicitly
| >>= randomiseLayout | ||
| evalRandT | ||
| (randomise defaultEnumArrowsInstance >>= randomiseLayout) | ||
| (mkStdGen timestamp) |
Member
There was a problem hiding this comment.
It seems that previously the timestamp was not actually used as seed for the randomness, instead just as recording when the instance was generated. Whereas the randomness was derived from just the internal random generator in IO.
It's debatable whether that was a good approach, but then that should be a separate issue.
For now, just making the code compile again, I would argue the behavior should not be changed from what it was before. That is, not initializing the randomness from the timestamp variable here, instead using IO's built-in PRNG. I think that would be achieved by using evalRandTIO instead of evalRandT.
Member
|
Same in the other places. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #34