Integrate exhaustiveness metadata into solution payload for printSolutionAndAssert APIs#44
Merged
Conversation
Copilot
AI
changed the title
[WIP] Integrate whether to mention exhaustiveness parameter into correct solution
Integrate exhaustiveness metadata into solution payload for printSolutionAndAssert APIs
May 30, 2026
Updated comments to clarify the purpose of parameters in printSolutionAndAssert and another function.
There was a problem hiding this comment.
Pull request overview
This PR refactors the solution-printing API so the exhaustiveness flag travels with the optional solution payload, keeping display content and phrasing metadata together.
Changes:
- Updates
printSolutionAndAssertandprintSolutionAndAssertWithMinimumto acceptMaybe (Bool, ArticleToUse, String). - Adapts
extendedMultipleChoiceandsingleChoicecall sites to construct the new tuple shape while preserving existing behavior. - Updates Haddock comments for the revised parameter model.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+344
to
+345
| => Maybe (Bool, ArticleToUse, String) | ||
| -- ^ potentially the correct solution to show, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printSolutionAndAssertandprintSolutionAndAssertWithMinimumpreviously split “exhaustiveness wording” (Bool) from the optional solution payload. This change folds that flag into the solution payload itself so “what to show” and “how to phrase it” are carried together.API shape change
Maybe (Bool, ArticleToUse, String)Boolparameter from both signatures.Call-site adaptation
extendedMultipleChoicenow injectsmentionExhaustivenessinto the optional solution tuple before callingprintSolutionAndAssertWithMinimum.singleChoicenow passes(False, articleToUse, solutionString)to preserve current wording behavior.Behavior preservation