Skip to content

Rename ActionMetadata.funtion_name to function_name #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Rename ActionMetadata.funtion_name to function_name #7560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flyteidl2/workflow/run_definition.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ message ActionMetadata {
string environment_name = 12;

// Function name
string funtion_name = 13;
string function_name = 13;

// Trigger name
string trigger_name = 14;
Expand Down
6 changes: 3 additions & 3 deletions runs/service/run_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,8 +1530,8 @@
// actionMetadataFromModel builds an ActionMetadata proto from DB model columns.
func actionMetadataFromModel(action *models.Action) *workflow.ActionMetadata {
metadata := &workflow.ActionMetadata{
ActionType: workflow.ActionType(action.ActionType),
FuntionName: action.FunctionName,
ActionType: workflow.ActionType(action.ActionType),
FunctionName: action.FunctionName,

Check failure on line 1534 in runs/service/run_service.go

View workflow job for this annotation

GitHub Actions / test (runs) 

unknown field FunctionName in struct literal of type workflow.ActionMetadata

Check failure on line 1534 in runs/service/run_service.go

View workflow job for this annotation

GitHub Actions / test (manager) 

unknown field FunctionName in struct literal of type workflow.ActionMetadata
}
if action.ParentActionName.Valid {
metadata.Parent = action.ParentActionName.String
Expand Down Expand Up @@ -1829,7 +1829,7 @@
// No-op, this should never happen.
}

metadata.FuntionName = action.FunctionName
metadata.FunctionName = action.FunctionName

Check failure on line 1832 in runs/service/run_service.go

View workflow job for this annotation

GitHub Actions / test (runs) 

metadata.FunctionName undefined (type *workflow.ActionMetadata has no field or method FunctionName)

Check failure on line 1832 in runs/service/run_service.go

View workflow job for this annotation

GitHub Actions / test (manager) 

metadata.FunctionName undefined (type *workflow.ActionMetadata has no field or method FunctionName)
metadata.Source = workflow.RunSource(workflow.RunSource_value[action.RunSource])

if action.TriggerName.Valid {
Expand Down
Loading