Skip to content

add ImageIdentifier.repository for custom-registry image lookups #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dansola wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add ImageIdentifier.repository for custom-registry image lookups #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions flyteidl2/imagebuilder/definition.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ option go_package = "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/imagebuilder"
// ImageIdentifier is how to identify an image
message ImageIdentifier {
string name = 1 [(buf.validate.field).string.min_len = 1];

// Optional registry/repository the image lives in, e.g.
// "<account>.dkr.ecr.<region>.amazonaws.com/<repo>" for an image built with a custom registry
// override (clone(registry=...)). When set, GetImage looks the image up there; when empty, the
// cluster's default repository is used.
string repository = 2;

@pingsutw pingsutw Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
string repository = 2;
string registry = 2;

@EngHabu EngHabu Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that we will concat these values to create the final image url to check on?

If that's the case, we do need registry, repo and I'm assuming name already has the version?

}

// Simple container to surface if image exists
Expand Down
18 changes: 16 additions & 2 deletions gen/go/flyteidl2/imagebuilder/definition.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions gen/go/flyteidl2/imagebuilder/definition.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 14 additions & 20 deletions gen/go/gateway/flyteidl2/imagebuilder/definition.swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 14 additions & 20 deletions gen/go/gateway/flyteidl2/imagebuilder/payload.swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading