Skip to content

[wip] artifacts#191

Draft
kumare3 wants to merge 22 commits into
mainfrom
artifacts
Draft

[wip] artifacts#191
kumare3 wants to merge 22 commits into
mainfrom
artifacts

Conversation

@kumare3

@kumare3 kumare3 commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Artifacts

Adds support for passing flyte.remote.Artifact instances as task inputs. When an
Artifact (or a list containing artifacts) is passed to a local run, it is unwrapped
into its underlying pb2["data"] payload before submission.

Recent changes

  • Merged latest main into the branch.
  • Artifact unwrapping now applies to positional args as well as keyword args
    (previously only kwargs were unwrapped).
  • Extracted the conversion into module-level _unwrap_artifacts /
    _unwrap_artifact_value helpers in flyte/_run.py.
  • Added unit tests in tests/test_run_artifact_unwrap.py covering single artifacts,
    lists of artifacts, mixed/plain values, and positional + keyword combinations.

🤖 Generated with Claude Code

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
@wild-endeavor

Copy link
Copy Markdown
Contributor

should we add modelcard and user specified metadata?

artifacts.Metadata(
    name="my_artifact", version="1.0", description="An example artifact created in create_artifact task",
    card=ModelCard("single.html"),
    custom={"a": "one", "b": {"c": 3}}
)

@kumare3

kumare3 commented Sep 18, 2025

Copy link
Copy Markdown
Contributor Author

should we add modelcard and user specified metadata?

artifacts.Metadata(
    name="my_artifact", version="1.0", description="An example artifact created in create_artifact task",
    card=ModelCard("single.html"),
    custom={"a": "one", "b": {"c": 3}}
)

Yes I want to, i was thinking we make ModelMetadata and DataMetadata?
Question is, how do we upload the modelcard, do we upload are part of artifact creation or should we do it at transform time, i think before right?

Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
@kumare3 kumare3 changed the title wip [wip] artifacts Sep 24, 2025
kumare3 and others added 12 commits October 1, 2025 21:16
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
# Conflicts:
#	src/flyte/_run.py
#	src/flyte/remote/__init__.py
Extract artifact->pb2["data"] conversion into module-level
_unwrap_artifacts/_unwrap_artifact_value helpers and apply to both
positional args and kwargs in _run_local. Add unit tests covering
single artifacts, lists of artifacts, mixed/plain values, and the
positional + keyword combinations.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants