Skip to content

fix: validate devtoolsOptionsUri in extensionEnabledState handler #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: validate devtoolsOptionsUri in extensionEnabledState handler #9834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf2e38
fix: validate devtoolsOptionsUri scheme and filename in extensionEnab…
adilburaksen May 16, 2026
1fe700f
fix: restrict devtools_options.yaml path check to exact filename
adilburaksen May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/devtools_shared/lib/src/server/handlers/_devtools_extensions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,19 @@ extension _ExtensionsApiHandler on Never {
final devtoolsOptionsFileUriString =
queryParams[ExtensionsApi.devtoolsOptionsUriPropertyName]!;
final devtoolsOptionsFileUri = Uri.parse(devtoolsOptionsFileUriString);

// Validate that the URI is a local file URI pointing to a
// 'devtools_options.yaml' file. Accepting arbitrary URIs from the query
// string would allow an untrusted caller to create or overwrite any file
// writable by the DevTools server process.
if (devtoolsOptionsFileUri.scheme != 'file' ||
!devtoolsOptionsFileUri.path.endsWith('/devtools_options.yaml')) {
return api.badRequest(
'Invalid devtoolsOptionsUri: must be a file: URI ending in '
"'devtools_options.yaml'.",
);
}

final extensionName = queryParams[ExtensionsApi.extensionNamePropertyName]!;

final activate = queryParams[ExtensionsApi.enabledStatePropertyName];
Expand Down