Skip to content

Changed buildId type to Int64#5054

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ievdokdm:latest_presubmit
May 21, 2026
Merged

Changed buildId type to Int64#5054
auto-submit[bot] merged 4 commits into
flutter:mainfrom
ievdokdm:latest_presubmit

Conversation

@ievdokdm
Copy link
Copy Markdown
Contributor

Changed buildId type to Int64 to correspond with Build.id type

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 20, 2026
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label May 20, 2026
@ievdokdm ievdokdm requested a review from jtmcdole May 20, 2026 18:13
@jtmcdole
Copy link
Copy Markdown
Member

fyi; integers in Firebase are strings:

{
  "name": "projects/flutter-dashboard/databases/cocoon/documents/presubmit_jobs/flutter_flutter_77007126988_Windows tool_integration_tests_10_10_1",
  "fields": {
    "end_time": {
      "integerValue": "1779299729174"
    },
    "slug": {
      "stringValue": "flutter/flutter"
    },
    "check_run_id": {
      "integerValue": "77007126988"
    },
    "creation_time": {
      "integerValue": "1779297745813"
    },
    "build_id": {
      "integerValue": "8681264797578057009"
    },
    "build_number": {
      "integerValue": "1880"
    },
    "summary": {
      "stringValue": ""
    },
    "attempt_number": {
      "integerValue": "1"
    },
    "status": {
      "stringValue": "Succeeded"
    },
    "start_time": {
      "integerValue": "0"
    },
    "job_name": {
      "stringValue": "Windows tool_integration_tests_10_10"
    }
  },
  "createTime": "2026-05-20T17:22:26.069120Z",
  "updateTime": "2026-05-20T17:55:29.733104Z"
}

@ievdokdm
Copy link
Copy Markdown
Contributor Author

fyi; integers in Firebase are strings:

{
  "name": "projects/flutter-dashboard/databases/cocoon/documents/presubmit_jobs/flutter_flutter_77007126988_Windows tool_integration_tests_10_10_1",
  "fields": {
    "end_time": {
      "integerValue": "1779299729174"
    },
    "slug": {
      "stringValue": "flutter/flutter"
    },
    "check_run_id": {
      "integerValue": "77007126988"
    },
    "creation_time": {
      "integerValue": "1779297745813"
    },
    "build_id": {
      "integerValue": "8681264797578057009"
    },
    "build_number": {
      "integerValue": "1880"
    },
    "summary": {
      "stringValue": ""
    },
    "attempt_number": {
      "integerValue": "1"
    },
    "status": {
      "stringValue": "Succeeded"
    },
    "start_time": {
      "integerValue": "0"
    },
    "job_name": {
      "stringValue": "Windows tool_integration_tests_10_10"
    }
  },
  "createTime": "2026-05-20T17:22:26.069120Z",
  "updateTime": "2026-05-20T17:55:29.733104Z"
}

made buildId in PresubmitJobResponse of type String?

@ievdokdm ievdokdm added CICD Run CI/CD and removed CICD Run CI/CD labels May 20, 2026
Comment thread app_dart/lib/src/request_handlers/analyze_logs.dart Outdated
Comment thread app_dart/lib/src/request_handlers/analyze_logs.dart
summary: job.summary,
buildNumber: job.buildNumber,
buildId: job.buildId,
buildId: job.buildId?.toString(),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildId: job.buildId?.toString(),
buildId: '${job.buildId}',

Comment thread dashboard/lib/service/appengine_cocoon.dart Outdated
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented May 21, 2026

autosubmit label was removed for flutter/cocoon/5054, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label May 21, 2026
@ievdokdm ievdokdm added CICD Run CI/CD and removed CICD Run CI/CD labels May 21, 2026
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label May 21, 2026
@auto-submit auto-submit Bot merged commit 1abc986 into flutter:main May 21, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants