Changed buildId type to Int64#5054
Merged
Merged
Conversation
Member
|
fyi; integers in Firebase are strings: {
"name": "projects/flutter-dashboard/databases/cocoon/documents/presubmit_jobs/flutter_flutter_77007126988_Windows tool_integration_tests_10_10_1",
"fields": {
"end_time": {
"integerValue": "1779299729174"
},
"slug": {
"stringValue": "flutter/flutter"
},
"check_run_id": {
"integerValue": "77007126988"
},
"creation_time": {
"integerValue": "1779297745813"
},
"build_id": {
"integerValue": "8681264797578057009"
},
"build_number": {
"integerValue": "1880"
},
"summary": {
"stringValue": ""
},
"attempt_number": {
"integerValue": "1"
},
"status": {
"stringValue": "Succeeded"
},
"start_time": {
"integerValue": "0"
},
"job_name": {
"stringValue": "Windows tool_integration_tests_10_10"
}
},
"createTime": "2026-05-20T17:22:26.069120Z",
"updateTime": "2026-05-20T17:55:29.733104Z"
} |
Contributor
Author
made |
jtmcdole
requested changes
May 21, 2026
| summary: job.summary, | ||
| buildNumber: job.buildNumber, | ||
| buildId: job.buildId, | ||
| buildId: job.buildId?.toString(), |
Member
There was a problem hiding this comment.
Suggested change
| buildId: job.buildId?.toString(), | |
| buildId: '${job.buildId}', |
Contributor
|
autosubmit label was removed for flutter/cocoon/5054, because This PR has not met approval requirements for merging. Changes were requested by {jtmcdole}, please make the needed changes and resubmit this PR.
|
jtmcdole
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed buildId type to Int64 to correspond with Build.id type