[flutter_webrtc] Remove Ecore API#1045
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the Ecore main loop thread-safe call with GLib's idle source (g_idle_add_full) in TaskRunnerTizen. Feedback focuses on managing the lifecycle of the GLib idle source by tracking its ID to prevent use-after-free crashes, avoiding redundant idle source scheduling, and executing tasks outside of the mutex lock to prevent deadlocks. Additionally, it is recommended to remove the unused <Ecore.h> header.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Use g_idle_add_full instead of ecore_main_loop_thread_safe_call_async - RunTask returns G_SOURCE_REMOVE to remove idle source after processing - Simplified implementation by removing idle_source_id_ tracking Co-Authored-By: Cline SR
2 participants
Use g_idle_add_full instead of ecore_main_loop_thread_safe_call_async