Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/tizen_package_manager/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.4.2

* Remove Ecore API.

## 0.4.1

* Fix error handling in `getPackageSizeInfo`.
Expand Down
2 changes: 1 addition & 1 deletion packages/tizen_package_manager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ To use this package, add `tizen_package_manager` as a dependency in your `pubspe

```yaml
dependencies:
tizen_package_manager: ^0.4.1
tizen_package_manager: ^0.4.2
```

### Retrieving specific package info
Expand Down
2 changes: 1 addition & 1 deletion packages/tizen_package_manager/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: tizen_package_manager
description: Tizen package manager APIs. Used to get information about packages installed on a Tizen device.
homepage: https://github.com/flutter-tizen/plugins
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/tizen_package_manager
version: 0.4.1
version: 0.4.2

environment:
sdk: ">=3.1.0 <4.0.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,21 @@

#include "tizen_package_manager_plugin.h"

#include <Ecore.h>
#include <flutter/encodable_value.h>
#include <flutter/event_channel.h>
#include <flutter/event_sink.h>
#include <flutter/event_stream_handler_functions.h>
#include <flutter/method_channel.h>
#include <flutter/plugin_registrar.h>
#include <flutter/standard_method_codec.h>
#include <glib.h>

#include <cstdint>
#include <memory>
#include <string>
#include <vector>

#include "log.h"
#include "tizen_package_manager.h"

namespace {
Expand Down Expand Up @@ -244,8 +245,10 @@ class TizenPackageManagerPlugin : public flutter::Plugin {
// TizenPackageManager::GetAllPackagesInfo() is an expensive operation and
// might cause unresponsiveness on low-end devices if run on the platform
// thread.
ecore_thread_run(
[](void *data, Ecore_Thread *thread) {
GError *error = nullptr;
GThread *thread = g_thread_try_new(
"flutter_tizen_plugins_tizen_package_manager_all_packages",
[](gpointer data) -> gpointer {
auto *result = static_cast<FlMethodResult *>(data);

TizenPackageManager &package_manager =
Expand All @@ -264,14 +267,22 @@ class TizenPackageManagerPlugin : public flutter::Plugin {
package_manager.GetLastErrorString());
}
delete result;
return nullptr;
},
nullptr,
[](void *data, Ecore_Thread *thread) {
auto *result = static_cast<FlMethodResult *>(data);
result->Error("Operation failed", "Failed to start a thread.");
delete result;
},
result.release());
result.get(), &error);

if (thread == nullptr) {
LOG_ERROR("Failed to create a thread: %s",
error ? error->message : "unknown error");
if (error) {
g_error_free(error);
}
result->Error("Operation failed", "Failed to start a thread.");
return;
}

result.release();
g_thread_unref(thread);
}

void GetPackageSizeInfo(const flutter::EncodableMap *arguments,
Expand Down
Loading