[flutter_secure_storage] Update integration tests based on upstream v10.2.0#1040
Open
seungsoo47 wants to merge 2 commits into
Open
[flutter_secure_storage] Update integration tests based on upstream v10.2.0#1040seungsoo47 wants to merge 2 commits into
seungsoo47 wants to merge 2 commits into
Conversation
…10.2.0 Replace the Tizen integration test with the upstream flutter_secure_storage v10.2.0 suite so it mirrors upstream's structure, using the upstream Linux integration tests (which exercise the public API and run on Tizen) as the source. The result is two groups — Basic CRUD and Special-character keys — with 12 test cases. The upstream app-level UI-driven tests and the Android/iOS-specific cases (namespace isolation, cipher migration, Secure Enclave) are not included, as they don't apply to Tizen. All of the previous Tizen tests are already covered by the upstream suite, so no Tizen-specific test needed to be preserved. This is a test-only change, so the version is not bumped; the changelog records it under a NEXT entry. Validated on a Tizen TV (10.0) and Raspberry Pi 4: all tests pass (12 passed, 0 skipped, 0 failed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests for flutter_secure_storage to align with upstream version 10.2.0, introducing 12 test cases grouped into 'Basic CRUD' and 'Special-character keys' and refactoring the test setup to use a global storage instance. Feedback on the changes points out a duplicate ## NEXT header in CHANGELOG.md that should be merged to prevent parsing issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Tizen integration test with the upstream flutter_secure_storage v10.2.0 suite so it mirrors upstream's structure, using the upstream Linux integration tests (which exercise the public API and run on Tizen) as the source. The result is two groups — Basic CRUD and Special-character keys — with 12 test cases.
The upstream app-level UI-driven tests and the Android/iOS-specific cases (namespace isolation, cipher migration, Secure Enclave) are not included, as they don't apply to Tizen. All of the previous Tizen tests are already covered by the upstream suite, so no Tizen-specific test needed to be preserved.
This is a test-only change, so the version is not bumped; the changelog records it under a NEXT entry.
Validated on a Tizen TV (10.0) and Raspberry Pi 4: all tests pass (12 passed, 0 skipped, 0 failed).
#1039