Skip to content

fix: #113 dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState - #154

Merged
deandreamatias merged 1 commit into
flutter-form-builder-ecosystem:mainfrom
MickaelTitecaTAO:fix/113
Jul 10, 2026
Merged

fix: #113 dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState#154
deandreamatias merged 1 commit into
flutter-form-builder-ecosystem:mainfrom
MickaelTitecaTAO:fix/113

Conversation

@MickaelTitecaTAO

Copy link
Copy Markdown
Contributor

Connection with issue(s)

Close #113

Solution description

Use the same logic than https://github.com/flutter-form-builder-ecosystem/flutter_form_builder/blob/main/lib/src/fields/form_builder_text_field.dart

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@MickaelTitecaTAO MickaelTitecaTAO changed the title fix(#113): dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState fix: dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState Jul 10, 2026
…only if it has been created inside FormBuilderTypeAheadState
@MickaelTitecaTAO MickaelTitecaTAO changed the title fix: dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState fix: #113 dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.13%. Comparing base (c615cdc) to head (ab708d6).

Files with missing lines Patch % Lines
lib/src/fields/form_builder_typeahead.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   56.39%   56.13%   -0.27%     
==========================================
  Files           5        5              
  Lines         211      212       +1     
==========================================
  Hits          119      119              
- Misses         92       93       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deandreamatias
deandreamatias merged commit 661db3f into flutter-form-builder-ecosystem:main Jul 10, 2026
6 of 9 checks passed
@deandreamatias

Copy link
Copy Markdown
Contributor

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FormBuilderTypeAhead]: Calls dispose on the TextEditingController even when it is passed in

2 participants