fix: #113 dispose _typeAheadController only if it has been created inside FormBuilderTypeAheadState - #154
Merged
deandreamatias merged 1 commit intoJul 10, 2026
Conversation
MickaelTitecaTAO
force-pushed
the
fix/113
branch
from
July 10, 2026 15:22
fc0c3df to
d23a5d8
Compare
MickaelTitecaTAO
force-pushed
the
fix/113
branch
from
July 10, 2026 15:24
d23a5d8 to
195a06a
Compare
…only if it has been created inside FormBuilderTypeAheadState
MickaelTitecaTAO
force-pushed
the
fix/113
branch
from
July 10, 2026 15:27
195a06a to
ab708d6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 56.39% 56.13% -0.27%
==========================================
Files 5 5
Lines 211 212 +1
==========================================
Hits 119 119
- Misses 92 93 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
deandreamatias
merged commit Jul 10, 2026
661db3f
into
flutter-form-builder-ecosystem:main
6 of 9 checks passed
Contributor
|
Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #113
Solution description
Use the same logic than https://github.com/flutter-form-builder-ecosystem/flutter_form_builder/blob/main/lib/src/fields/form_builder_text_field.dart
Screenshots or Videos
To Do