fix: [FL-29714] patch Snyk x/net/html and x/sys/windows vulnerabilities#101
Merged
Merged
Conversation
Add replace directives to pin golang.org/x/net to v0.55.0 (fixes 5 CVE-2026-* XSS and CPU exhaustion vulns in x/net/html) and golang.org/x/sys to v0.44.0 (fixes CVE-2026-39824 integer overflow in x/sys/windows). Add .snyk safety-net ignores for all 6 CVEs.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
Pins vulnerable transitive Go dependencies (golang.org/x/net, golang.org/x/sys) to patched versions and adds Snyk ignore entries as a backstop for reported CVEs.
Changes:
- Add
replacedirectives to forcegolang.org/x/net v0.55.0andgolang.org/x/sys v0.44.0. - Add
.snykignore entries for the 6 reported CVEs (x/net/html + x/sys/windows). - Mirror the module pinning in
_examples/go.modfor the example module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Adds replace directives to pin x/net and x/sys to patched versions. |
| .snyk | Adds ignore entries for the 6 Snyk vulnerability IDs with expiry/created metadata. |
| _examples/go.mod | Mirrors the replace directives for the example module dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
josue
commented
May 27, 2026
Collaborator
Author
josue
left a comment
josue
left a comment
There was a problem hiding this comment.
Adversarial Review — PR #101 (Snyk x/net + x/sys vulnerability patches)
Reviewers: Claude Opus (Gemini 2.5 Pro rate-limited, Claude performed full review)
New Findings: 2
| Severity | Finding | File |
|---|---|---|
| MEDIUM | .snyk x/net/html ignores lack "not imported/compiled" attestation — SOC 2 audit gap |
.snyk:256-293 |
| LOW | .snyk x/sys/windows ignore should note build-tag guard |
.snyk:294-301 |
Copilot Comments: Both Fixed
Both Copilot comments about missing go.sum entries were valid and have been addressed in commit 2ef9970. Replies posted below.
Verification
govulncheck ./...→ No vulnerabilities foundgo list -m→ x/net v0.55.0, x/sys v0.44.0 effectivego mod why golang.org/x/net/html→ not needed by main modulex/sys/windowsbuild-tag guarded, not compiled on linux/darwin- All CI checks green, Snyk reports 0 issues
Add explicit "not compiled into any binary" attestation to x/net/html ignores and note build-tag constraint for x/sys/windows ignore.
Upgrade google.golang.org/grpc v1.80.0 → v1.81.1 which transitively pulls otel v1.43.0 and go-jose v4.1.4, fixing all flagged CVEs: - 7 OpenTelemetry CVEs: CVE-2026-24051 (sdk/resource), CVE-2026-29181 (baggage, internal/global, internal/errorhandler, propagation), CVE-2026-39882 (otlpmetrichttp, otlptracehttp), CVE-2026-39883 (sdk/resource) — all fixed in otel v1.43.0 - 4 go-jose CVEs: CVE-2026-34986 + signature verification issue — all fixed in go-jose v4.1.4 Remove go-jose replace directive from both go.mod files (grpc v1.81.1 natively requires v4.1.4). Remove 11 .snyk safety-net ignores that are no longer needed. Reduces .snyk ignore count from 35 to 24 (31%). Verified: govulncheck clean, go mod why confirms all removed packages are ghost deps, all tests pass.
corvramirez
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace golang.org/x/net => golang.org/x/net v0.55.0to fix 5 CVE-2026-* vulnerabilities inx/net/html(XSS + CPU exhaustion)replace golang.org/x/sys => golang.org/x/sys v0.44.0to fix CVE-2026-39824 inx/sys/windows(integer overflow)google.golang.org/grpcv1.80.0 → v1.81.1 to resolve 11 additional Snyk vulnerabilities (7 otel + 4 go-jose)go-jose/v4replace directive (grpc v1.81.1 natively requires v4.1.4).snyksafety-net ignores now fixed by the grpc upgrade (35 → 24 ignores, 31% reduction).snyksafety-net ignores for the 6 x/net + x/sys CVEsVulnerabilities Fixed
x/net + x/sys (replace directives)
OpenTelemetry (fixed by grpc v1.81.1 → otel v1.43.0)
go-jose (fixed by grpc v1.81.1 → go-jose v4.1.4)
Test plan
go test ./(unit tests) — passcd _examples && go test ./.(integration tests) — passgovulncheck ./...— zero vulnerabilitiesgo list -mconfirmsx/net v0.55.0,x/sys v0.44.0,grpc v1.81.1go mod whyconfirms otel + go-jose packages are ghost deps.snykYAML validation — valid, 24 ignores remainingJIRA: FL-29714