Skip to content

fix: patch Snyk x/crypto SSH and Go stdlib vulnerabilities#100

Merged
josue merged 2 commits into
mainfrom
fix/FL-29711-patch-snyk-vulnerabilities
May 26, 2026
Merged

fix: patch Snyk x/crypto SSH and Go stdlib vulnerabilities#100
josue merged 2 commits into
mainfrom
fix/FL-29711-patch-snyk-vulnerabilities

Conversation

@josue
Copy link
Copy Markdown
Collaborator

@josue josue commented May 26, 2026

Summary

  • Bump golang.org/x/crypto replace directive from v0.50.0 → v0.52.0 to fix 11 CVE-2026-* vulnerabilities in x/crypto/ssh, ssh/agent, and ssh/knownhosts
  • Bump Go from 1.26.2 → 1.26.3 to fix 8 stdlib vulnerabilities in std/net, net/http, html/template, net/mail, and net/http/httputil
  • Update .snyk safety-net ignores for the new CVEs (replaces old CVE-2025-* entries with CVE-2026-* entries)

Vulnerabilities Fixed

golang.org/x/crypto (11 CVEs — all fixed in v0.52.0)

CVE Package Severity
CVE-2026-39831 ssh High (8.6)
CVE-2026-46597 ssh High (8.7)
CVE-2026-39835 ssh High (8.7)
CVE-2026-39827 ssh High (7.1)
CVE-2026-46598 ssh/agent High (8.7)
CVE-2026-42508 ssh/knownhosts High (8.7)
CVE-2026-39830 ssh Medium (6.9)
CVE-2026-39828 ssh Medium (5.3)
CVE-2026-46595 ssh Medium (5.3)
CVE-2026-39832 ssh/agent Medium (5.3)
CVE-2026-39833 ssh/agent Medium (5.3)

Go stdlib (8 CVEs — all fixed in Go 1.26.3)

std/net Double Free (CVE-2026-33811), net/http Infinite Loop, html/template XSS bypasses (x2), net/mail quadratic concat (x2), net/http/httputil query param forwarding

Note: golang.org/x/crypto is a transitive ghost dependency pulled in by hashicorp/hcl/v2 — it is never imported or compiled into any binary from this project.

Test plan

  • go test ./ (unit tests) — pass
  • cd _examples && go test ./. (integration tests) — pass
  • govulncheck -show verbose ./... — zero vulnerabilities at all levels
  • CI passes (linting, formatting, tests)

JIRA: FL-29711

Bump golang.org/x/crypto replace directive from v0.50.0 to v0.52.0 to
fix 11 CVE-2026-* vulnerabilities in x/crypto/ssh, ssh/agent, and
ssh/knownhosts. Bump Go from 1.26.2 to 1.26.3 to fix 8 stdlib vulns
in std/net, net/http, html/template, net/mail, and net/http/httputil.

Update .snyk safety-net ignores for the new CVEs (transitive ghost deps
that Snyk may still flag despite the replace directive).
Copilot AI review requested due to automatic review settings May 26, 2026 18:33
@josue josue requested a review from caseyh as a code owner May 26, 2026 18:33
@flume-bot
Copy link
Copy Markdown

flume-bot commented May 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go toolchain and the pinned golang.org/x/crypto version to address newly reported Snyk vulnerabilities, and refreshes .snyk ignore entries to match the new CVE set.

Changes:

  • Bump Go version from 1.26.2 to 1.26.3 across workspace and modules.
  • Update replace golang.org/x/crypto from v0.50.0 to v0.52.0 (root + _examples).
  • Replace prior .snyk ignore entries with updated Snyk IDs/CVE-2026-* rationale blocks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
go.work Updates workspace Go version to 1.26.3.
go.mod Updates module Go version and pins golang.org/x/crypto via replace to v0.52.0.
.snyk Refreshes ignore entries for updated Snyk findings/CVEs related to golang.org/x/crypto.
_examples/go.mod Keeps examples module aligned with Go 1.26.3 and x/crypto v0.52.0 replace pin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .snyk Outdated
@josue josue changed the title fix: [FL-29711] patch Snyk x/crypto SSH and Go stdlib vulnerabilities fix: patch Snyk x/crypto SSH and Go stdlib vulnerabilities May 26, 2026
Update section comment from "not in go.mod" to "not a direct require"
since a replace directive for x/crypto does exist in go.mod.
@josue josue merged commit e10a05b into main May 26, 2026
8 checks passed
@josue josue deleted the fix/FL-29711-patch-snyk-vulnerabilities branch May 26, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants