plugin_proxy: add config map to the plugin registration by iypetrov · Pull Request #12058 · fluent/fluent-bit

iypetrov · 2026-07-06T07:39:09Z

Extend the proxy plugin registration flow so input and output Go plugins can attach a flb_config_map schema, enabling the same property validation native plugins already receive. Custom plugins are excluded because they don't go through the property-check callback path. For more context can check this discussion.

Issue #11776

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

Example configuration file for the change
Debug log output from testing the change

Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Run local packaging test showing all targets (including any new ones) build.
Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

Documentation required for this feature

Backporting

Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

Bug Fixes
- Plugin registration now correctly propagates plugin configuration settings when creating proxy-based input, output, and custom plugins.
- This improves consistency for plugins that depend on custom configuration data during initialization.

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>

coderabbitai · 2026-07-06T07:39:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1464a107-5dc7-43ee-aa48-79cae589c5a0

📥 Commits

Reviewing files that changed from the base of the PR and between a2aacd8 and d40d032.

📒 Files selected for processing (1)

src/flb_plugin_proxy.c

📝 Walkthrough

Walkthrough

Adds config_map to flb_plugin_proxy_def and propagates it to output, input, and custom plugin instances during proxy registration. A related registration comment is also updated.

Changes

Proxy Config Map Propagation

Layer / File(s)	Summary
Struct field and registration wiring `include/fluent-bit/flb_plugin_proxy.h`, `src/flb_plugin_proxy.c`	Adds the `config_map` pointer to `flb_plugin_proxy_def` and assigns it to output, input, and custom plugin proxy instances during registration. Updates a related comment.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: edsiper

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding config map support to plugin proxy registration.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2aacd87b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-06T07:43:28Z

+    char *name;                         /* plugin short name                           */
+    char *description;                  /* plugin description                          */
+    int event_type;                     /* event type (logs/metrics/traces)            */
+    struct flb_config_map *config_map;  /* plugin's configuration                      */


Propagate proxy config maps to custom plugins

When a Go proxy registers as FLB_PROXY_CUSTOM_PLUGIN and sets this new field, it is dropped because flb_proxy_register_custom() only copies flags/name/description into struct flb_custom_plugin. The custom path does have config-map validation (flb_custom_plugin_property_check() gates on p->config_map), so those plugins will silently accept unknown properties and won't get defaults/dynamic-env handling even though input/output proxy plugins do.

Useful? React with 👍 / 👎.

@iypetrov We need to apply the same operation which is like copying config_map on the proxy of custom plugins. So, could you add copying operation line into flb_proxy_register_custom() as well?

iypetrov · 2026-07-06T15:11:02Z

@cosmo0920 @edsiper

iypetrov · 2026-07-09T20:30:35Z

@cosmo0920 when you have time, can you rerun the failing tests?

iypetrov · 2026-07-09T20:33:15Z

@edsiper this PR implements the suggestion from #11788 (comment) - when this one got merged, I will close the PR with previous implementation in fluent-bit repo and will start working on the required change in fluent-bit-go.

iypetrov · 2026-07-22T06:56:23Z

@cosmo0920 @edsiper this PR is related to the discussion we had here.

cosmo0920

Mostly, I like this idea more than the previous one. One thing, we need to align the registration in each of plugin types. So, could you add the similar diffs in custom plugins' proxy?

cosmo0920 · 2026-07-30T06:39:28Z

+    char *name;                         /* plugin short name                           */
+    char *description;                  /* plugin description                          */
+    int event_type;                     /* event type (logs/metrics/traces)            */
+    struct flb_config_map *config_map;  /* plugin's configuration                      */


@iypetrov We need to apply the same operation which is like copying config_map on the proxy of custom plugins. So, could you add copying operation line into flb_proxy_register_custom() as well?

iypetrov · 2026-07-30T07:15:16Z

Mostly, I like this idea more than the previous one. One thing, we need to align the registration in each of plugin types. So, could you add the similar diffs in custom plugins' proxy?

Thanks for the feedback, I will make the adjustments.

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>

iypetrov · 2026-07-30T20:18:36Z

@cosmo0920 when you have time can you rerun the failing test, I think it is a flake

plugin_proxy: add config map arg to the plugin registration

a2aacd8

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>

iypetrov requested review from cosmo0920 and edsiper as code owners July 6, 2026 07:39

github-actions Bot added the docs-required label Jul 6, 2026

iypetrov changed the title ~~plugin_proxy: add config map arg to the plugin registration~~ plugin_proxy: add config map to the plugin registration Jul 6, 2026

chatgpt-codex-connector Bot reviewed Jul 6, 2026

View reviewed changes

iypetrov temporarily deployed to pr July 7, 2026 08:05 — with GitHub Actions Inactive

iypetrov temporarily deployed to pr July 7, 2026 08:35 — with GitHub Actions Inactive

iypetrov mentioned this pull request Jul 28, 2026

kv: add flb_kv_get_all_key_values function #11788

Open

7 tasks

cosmo0920 requested changes Jul 30, 2026

View reviewed changes

plugin_proxy: copy the plugin config on the custom plugins as well

d40d032

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>

iypetrov temporarily deployed to pr July 30, 2026 16:06 — with GitHub Actions Inactive

iypetrov temporarily deployed to pr July 30, 2026 16:39 — with GitHub Actions Inactive

iypetrov temporarily deployed to pr July 30, 2026 16:40 — with GitHub Actions Inactive

iypetrov requested a review from cosmo0920 July 31, 2026 11:26

Uh oh!

Conversation

iypetrov commented Jul 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

cosmo0920 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

iypetrov commented Jul 6, 2026

Uh oh!

iypetrov commented Jul 9, 2026

Uh oh!

iypetrov commented Jul 9, 2026

Uh oh!

iypetrov commented Jul 22, 2026

Uh oh!

cosmo0920 left a comment

Choose a reason for hiding this comment

Uh oh!

cosmo0920 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

iypetrov commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iypetrov commented Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iypetrov commented Jul 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

iypetrov commented Jul 30, 2026 •

edited

Loading