s3: document format=parquet option and page-level compression - #2591
Conversation
Update S3 output plugin documentation to reflect the new format=parquet option that separates output format selection from byte-level compression. Documents: - New parquet value for the format option - Page-level compression codec control via compression when format is parquet - Migration path from deprecated compression=parquet syntax - Configuration examples with and without page-level compression - Updated existing parquet examples to use new syntax Related code PR: fluent/fluent-bit#11885 Signed-off-by: Rituparna Khaund <ritukhau@amazon.co.uk>
📝 WalkthroughWalkthroughThis PR updates S3 output documentation for Parquet configuration, compression codecs, upload requirements, migration from deprecated settings, Arrow output clarification, and testing examples. ChangesS3 Output Parquet Format Documentation
Estimated code review effort: 2 (Simple) | ~8 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tions - Wrap `codec` in backticks for linting issue - Replace "are not" with "aren't" for linting isse Applies to fluent#2591 Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
left a comment
There was a problem hiding this comment.
@rituparnakhaund thanks for the docs PR, I pushed a fix for vale issues and now just waiting on code PR merging.
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Code PR merged, fixed small conflict. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pipeline/outputs/s3.md (2)
194-199: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winInclude the required
use_put_objectsetting in the migration example.The recommended block is incomplete: Parquet requires
use_put_object: on, but users replacing onlycompression: parquetwill retain the unsupported multipart-upload mode.**After (recommended):** ```yaml +use_put_object: on format: parquet compression: snappy<details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@pipeline/outputs/s3.mdaround lines 194 - 199, Update the recommended YAML
migration example in the “After” block to include the required use_put_object:
on setting alongside format and compression, ensuring Parquet output uses
PUT-object uploads.</details> <!-- cr-comment:v1:8fa744ff363a38676b7b83b9 --> --- `49-49`: _🗄️ Data Integrity & Integration_ | _🟡 Minor_ | _⚡ Quick win_ **Clarify the Parquet compression contract.** The table omits `uncompressed`, despite the documented uncompressed-page example. It also conflicts with the generic statement that S3 objects are compressed before upload; for Parquet, `compression` selects the page codec rather than an outer object-compression layer. Include `uncompressed` and explicitly qualify the generic compression guidance. <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@pipeline/outputs/s3.mdat line 49, Update the compression entry in the S3
outputs documentation to include uncompressed as a supported Parquet page codec,
and clarify that for format parquet the compression value controls the internal
page codec rather than compressing the uploaded S3 object; qualify the generic
object-compression guidance accordingly.</details> <!-- cr-comment:v1:115e1aa91ef03949a41bc759 --> </blockquote></details> </blockquote></details>🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Outside diff comments: In `@pipeline/outputs/s3.md`: - Around line 194-199: Update the recommended YAML migration example in the “After” block to include the required use_put_object: on setting alongside format and compression, ensuring Parquet output uses PUT-object uploads. - Line 49: Update the compression entry in the S3 outputs documentation to include uncompressed as a supported Parquet page codec, and clarify that for format parquet the compression value controls the internal page codec rather than compressing the uploaded S3 object; qualify the generic object-compression guidance accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID:
6b9664b9-ebee-43ac-b01f-bea86a5aa5ba📒 Files selected for processing (1)
pipeline/outputs/s3.md
Update S3 output plugin documentation to reflect the new format=parquet option that separates output format selection from byte-level compression.
Documents:
Related code PR: fluent/fluent-bit#11885
Summary by CodeRabbit
compressionoptions (includingzstdandarrow) and clarified howformataffects Parquet behavior.compression=parquet.format: parquetwithcompression: snappy.