Feature/resources#42
Open
HannesBachter wants to merge 28 commits into
Open
Conversation
floweisshardt
requested changes
Mar 14, 2017
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
How do I do that? Just remove them or use some git-magic?
| Method that returns the metric method with the given parameter. | ||
| :param params: Parameter | ||
| """ | ||
| print "pathlength params:", params |
| del metric['groundtruth_epsilon'] | ||
| except (TypeError, KeyError): | ||
| rospy.logwarn( | ||
| "No groundtruth parameters given, skipping groundtruth evaluation for metric 'path_length' in testblock '%s'", |
| metrics = CalculateResources(self.params) | ||
|
|
||
| metrics = [] | ||
|
|
Owner
There was a problem hiding this comment.
add block for checking list type
if type(params) is not list:
rospy.logerr("metric config not a list")
return False
| groundtruth_result = False | ||
|
|
||
| #print "node data: ", self.node_data, "\n groundthruth result", groundtruth_result, " \n .................................." | ||
| return "resources", self.node_data, groundtruth_result, self.groundtruth, self.groundtruth_epsilon, "*resources details*" |
Owner
There was a problem hiding this comment.
let's use details = None if there is no usefull things to wrap in here. see https://github.com/ipa-fmw/atf/blob/master/atf_metrics/src/atf_metrics/calculate_time.py#L68
added 6 commits
March 19, 2017 12:40
…recording Conflicts: .gitignore atf_metrics/config/metrics.yaml
HannesBachter
commented
Mar 21, 2017
| self.test_config = config_file | ||
| def __init__(self, write_lock, bag_file_writer): | ||
| self.topic_prefix = "atf/" | ||
| file = "/home/fmw-hb/workshop_catkin_ws/src/msh_test/hannes_test_msh/config/test_configs/test2.yaml" |
Contributor
Author
There was a problem hiding this comment.
where can I get the test config (or the path to it) from?
HannesBachter
commented
Mar 21, 2017
| elif msg.trigger == TestblockTrigger.STOP: | ||
| print "STOP Trigger" | ||
|
|
||
| def create_testblock_list(self): |
Contributor
Author
There was a problem hiding this comment.
is there a chance to get the testblock list from somewhere else?
added 11 commits
March 21, 2017 15:45
Conflicts: .gitignore atf_core/src/atf_core/recorder.py atf_metrics/config/metrics.yaml atf_metrics/src/atf_metrics/check_localization.py atf_presenter/scripts/presenter.py hannes_test/config/test_configs/test1.yaml hannes_test/config/test_generation_config.yaml hannes_test/config/test_suites.yaml hannes_test/launch/application.launch hannes_test/scripts/application.py
HannesBachter
commented
Jul 5, 2017
| self.test_config = config_file | ||
| def __init__(self, write_lock, bag_file_writer): | ||
| self.topic_prefix = "atf/" | ||
| file = "/home/fmw-hb/atf_catkin_ws/src/atf/hannes_test/config/test_configs/test1.yaml" |
Contributor
Author
There was a problem hiding this comment.
need to get the test config otherwise, but don't know how
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added metric for resources