fix: add TLS session resumption#1304
Open
mavonx wants to merge 1 commit into
Open
Conversation
floatpanebot
added
bug
FromSi
requested changes
May 18, 2026
| MinVersion: tls.VersionTLS12, | ||
| ClientSessionCache: account.ClientSessionCache, | ||
| VerifyConnection: func(cs tls.ConnectionState) error { | ||
| log.Printf("SMTP connection resumed: %t", cs.DidResume) |
Member
There was a problem hiding this comment.
?
log.Printf("IMAP TLS session resumed: %t", cs.DidResume)| if a.ClientSessionCache == nil { | ||
| a.ClientSessionCache = tls.NewLRUClientSessionCache(64) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
If the same account is used concurrently, for example by a background IMAP reconnect and an SMTP send, this can cause a data race during the first cache initialization. It would be better to initialize the cache up front when loading/creating the account, or protect it with a mutex / sync.Once.
Member
|
@andrinoff Need to verify the expected behavior:
I'm not entirely sure if this is implemented correctly or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Configured
TLSsession resumption forIMAPandSMTP.Why?
Reduce reconnect latency by avoiding full
TLShandshakes.Closes #1174