feat: add pricing warnings for missing model entries in pricing tables #36
Merged
Conversation
- Enhanced `DiffOutcome` to include `pricing_warnings`, a tuple of strings indicating when a model is not found in the baseline or candidate pricing tables. - Updated `compute_diff` function to populate `pricing_warnings` based on the presence of entries in the pricing tables. - Modified the `post_diff` route to return `pricing_warnings` in the response. - Introduced a new `MetricsPayload` type in the API to reflect the updated response structure. - Updated the web UI to display pricing warnings when applicable, enhancing user awareness of potential issues. - Added tests to verify the correct behavior of pricing warnings in various scenarios, including when models are missing from pricing tables. This change improves the diagnostic capabilities of the system, allowing users to better understand pricing discrepancies during release diffs.
…atic assets directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Changes
Validation
Run the same checks as CI (see
.github/workflows/ci.yml) before opening / updating the PR. Cursor loads.cursor/rules/flightdeck-ci-artifacts.mdcas a short reminder forstatic/+schemas/gates.uv sync --frozen --extra devuv run python -m ruff check src testsuv run python -m pytestuv run python scripts/generate_schemas.pythengit diff --exit-code schemas/(if models/schemas touched)cd web && npm ci && npm run build && cd .. && git diff --exit-code src/flightdeck/server/static/(ifweb/sources, Vite config, orweb/deps / lockfile change the production bundle)cd web && npx playwright install chromium && npm run test:e2e(ifweb/changed)uv run flightdeck-quickstart-verifyuv run flightdeck --helpWith pip / venv only, use
python -m …equivalents fromDEVELOPMENT.md.Schema / Storage Impact
Risk
Review
@flightdeckdev/maintainerson the org repo). On a fork, GitHub may not auto-request; use Reviewers on the PR.AGENTS.md); linked issue or release note intent noted if helpful.Notes