Skip to content

Fix layout for LoginPage#716

Open
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:fix-login-page-layout
Open

Fix layout for LoginPage#716
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:fix-login-page-layout

Conversation

@celdrake

@celdrake celdrake commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Adding fctl-app main div broke the styling for the LoginPages, moving the content to the top rather than it being vertically aligned.

display:contents cannot be applied globally as it was affecting the OCP plugin layout, see b3c9493

fix-layout

Updated apps/standalone/ login page layout CSS by making the top-level .fctl-app container use display: contents so routed content can inherit the root height and render vertically centered again.

This is a standalone app change only; it does not modify shared UI components, types, i18n, Cypress tests, the Go auth proxy, packaging, or CI. The change is intentionally scoped to avoid impacting the OCP plugin layout.

Made-with: Cursor
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: d4fdaadb-2834-4e57-a5c8-6448b831622c

📥 Commits

Reviewing files that changed from the base of the PR and between 6a62298 and 4a91056.

📒 Files selected for processing (1)
  • apps/standalone/src/app/app.css

Walkthrough

Adds a CSS rule in app.css for #root > .fctl-app with display: contents, allowing routed child components to participate directly in #root's height layout flow.

Standalone App CSS Fix

Layer / File(s) Summary
Add display: contents to .fctl-app
apps/standalone/src/app/app.css
A new rule targeting #root > .fctl-app sets display: contents so the wrapper element is invisible to layout, letting routed pages inherit #root's height directly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

standalone

Poem

A wrapper that hides, yet lets children grow tall,
display: contents — the box that's no box at all.
The #root stretches high, its children flow free,
Four lines of CSS, simple as can be. 🎨

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Unchecked-Errors ⚠️ Warning proxy/bridge/handler.go and terminal.go add unchecked _ error ignores with no justification: json.Marshal, resp.Body.Close(), and WriteControl. Handle or log those errors, or add a brief comment explaining why each can be safely ignored.
Generated-Files-Not-Hand-Edited ⚠️ Warning HEAD vs main shows libs/i18n/locales/en/translation.json modified with new/removed strings, which is a generated file. Regenerate translations with npm run i18n (or revert manual edits) and commit the generated output instead of hand-editing it.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: restoring LoginPage layout after the fctl-app container regression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The only changed app.css contains layout CSS only; no API keys, tokens, passwords, private keys, embedded creds, or long base64 strings appear.
No-Weak-Crypto ✅ Passed PASS: The PR only adds a CSS rule in app.css; no crypto primitives, custom crypto, or secret comparisons are present in the changed code.
No-Injection-Vectors ✅ Passed PR only adds a CSS rule in app.css; no eval/exec/dangerouslySetInnerHTML/yaml.load sink was introduced.
Container-Privileges ✅ Passed PR only changes app.css; manifest search found no privileged/container security settings (only the check config mentions them).
No-Sensitive-Data-In-Logs ✅ Passed PASS: The diff adds only layout/UI changes; no new console/logger/print statements or secret-bearing logs were introduced in changed files.
Resource-Leaks ✅ Passed PR only changes apps/standalone/src/app/app.css; no Go files under proxy/ were touched, so the resource-leak check is not applicable.
Ai-Attribution ✅ Passed HEAD commit includes the acceptable "Made-with: Cursor" trailer, and no Co-Authored-By AI attribution appears in the message.
I18n-Compliance ✅ Passed PASS: PR only changes apps/standalone/src/app/app.css; no .tsx files were modified, so there are no new user-visible strings or t() key usages to audit.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant