Skip to content

[release-1.0] Backport: Patch CVE-2025-61729 in Go proxy#711

Merged
celdrake merged 1 commit into
flightctl:release-1.0from
amir-yogev-gh:cve-fix/CVE-2025-61729-release-1.0
Jun 29, 2026
Merged

[release-1.0] Backport: Patch CVE-2025-61729 in Go proxy#711
celdrake merged 1 commit into
flightctl:release-1.0from
amir-yogev-gh:cve-fix/CVE-2025-61729-release-1.0

Conversation

@amir-yogev-gh

Copy link
Copy Markdown
Collaborator

CVE Fix

Vulnerabilities Addressed

CVE ID Severity Package Old Version New Version
CVE-2025-61729 HIGH (CVSS 7.5) Go stdlib crypto/x509 go 1.24.0 / toolchain go1.25.8 go 1.25.0 / toolchain go1.25.9

Description

CVE-2025-61729 is a Denial of Service vulnerability in Go's crypto/x509 package. A malicious X.509 certificate with a large number of Subject Alternative Names causes quadratic runtime in HostnameError.Error(), leading to CPU/memory exhaustion. Fixed in Go 1.24.11 and Go 1.25.5+.

The proxy/ component directly imports crypto/x509 and crypto/tls, making it susceptible.

Strategy Justification

CVE-2025-61729 — Go crypto/x509

# Strategy Result Details
1 Direct update (minor) Success Bumped Go version to go 1.25.0 / toolchain go1.25.9 in proxy/go.mod (matching backend)

Changes

  • proxy/go.mod: Updated go directive from 1.24.0 to 1.25.0, toolchain from go1.25.8 to go1.25.9

Validation

  • Dependencies: Updated to fixed version (go1.25.9 >= fix threshold go1.25.5)
  • Vulnerability scan: govulncheck binary scan confirms CVE-2025-61729 is not present
  • Tests: Pre-existing failure in auth/redirect_test.go (unrelated to this change)

Rollback

To revert this change:

git revert <commit-sha>

Resolves CVE-2025-61729 (HIGH) in Go stdlib crypto/x509.
Updated Go from 1.24.0 (toolchain 1.25.8) to 1.25.0 (toolchain 1.25.9)
in proxy/go.mod, matching the backend repository.

Assisted-by: Claude <noreply@anthropic.com>
(cherry picked from commit d036294)
@amir-yogev-gh amir-yogev-gh marked this pull request as ready for review June 29, 2026 14:36
@amir-yogev-gh amir-yogev-gh requested a review from celdrake June 29, 2026 14:36
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5dec86c6-dc8d-40ce-becf-750a6b40d353

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@celdrake celdrake changed the title Backport: Patch CVE-2025-61729 in Go proxy [release-1.0] Backport: Patch CVE-2025-61729 in Go proxy Jun 29, 2026
@celdrake celdrake merged commit a03a660 into flightctl:release-1.0 Jun 29, 2026
6 checks passed
@amir-yogev-gh amir-yogev-gh deleted the cve-fix/CVE-2025-61729-release-1.0 branch June 29, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants