Patch CVE-2025-61729 in Go proxy#710
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesGo Toolchain Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 13 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
e25c152 to
f8ac048
Compare
Resolves CVE-2025-61729 (HIGH) in Go stdlib crypto/x509. Updated Go from 1.24.0 (toolchain 1.25.8) to 1.25.0 (toolchain 1.25.9) in proxy/go.mod, matching the backend repository. Assisted-by: Claude <noreply@anthropic.com>
f8ac048 to
d036294
Compare
CVE Fix
Vulnerabilities Addressed
crypto/x509Description
CVE-2025-61729 is a Denial of Service vulnerability in Go's
crypto/x509package. A malicious X.509 certificate with a large number of Subject Alternative Names causes quadratic runtime inHostnameError.Error(), leading to CPU/memory exhaustion. Fixed in Go 1.24.11 and Go 1.25.5+.The
proxy/component directly importscrypto/x509andcrypto/tls, making it susceptible.Strategy Justification
CVE-2025-61729 — Go crypto/x509
go 1.25.0/toolchain go1.25.9in proxy/go.mod (matching backend)Changes
proxy/go.mod: Updatedgodirective from1.24.0to1.25.0,toolchainfromgo1.25.8togo1.25.9Validation
auth/redirect_test.go(unrelated to this change)Rollback
To revert this change:
Updated
proxy/(Go auth proxy) to patch HIGH-severity CVE-2025-61729 in Go’scrypto/x509by bumpingproxy/go.modfromgo 1.24.0→go 1.25.0and the toolchain fromgo1.25.8→go1.25.9. This change is confined to the Go proxy; it does not affect shared UI components (libs/ui-components/), shared types/i18n (libs/types/,libs/i18n/), Cypress E2E (libs/cypress/), platform-specific app code (apps/standalone/,apps/ocp-plugin/), packaging, or CI configuration (.github/workflows/). Validation includes agovulncheckscan confirming the CVE is not present after the update, noting an unrelated pre-existing test failure inauth/redirect_test.go.