EDM-4157: [SPUR] Add divider before Delete

[bugs-buddy-jira-ai-issue-solver]

Resolves EDM-4157

Summary

Add PatternFly dividers before destructive actions in all action dropdown menus across the application.

Fixes EDM-4157

Details

Destructive actions (Delete, Decommission, Remove, Cancel) were listed in dropdown menus without visual separation from non-destructive actions, violating PatternFly conventions and increasing risk of accidental data loss.

This PR adds standard PatternFly dividers before the first destructive action in every action menu:

• Table row kebab menus (7 files): Uses { isSeparator: true } in IAction[] arrays, which PatternFly's ActionsColumn natively renders as a <Divider />
• Detail page action dropdowns (6 files): Uses <Divider component="li" /> inside <DropdownList>
• Catalog page action dropdown (1 file): Uses <Divider component="li" />

Dividers are conditionally rendered to avoid showing when the destructive action is the only menu item.

Affected menus

Page	Destructive action
Enrolled devices table	Decommission device
Decommissioned devices table	Delete device
Device details	Decommission device
Fleets table	Delete fleet
Fleet details	Delete fleet
Image builds table	Cancel / Delete image build
Image build details	Cancel / Delete image build
Repositories table	Delete repository
Repository details	Delete repository
Auth providers table	Delete
Auth provider details	Delete authentication provider
Enrollment requests table	Delete
Enrollment request details	Delete
Catalog page	Remove

Test plan

• Verify TypeScript compilation passes (tsc --noEmit)
• Verify ESLint passes on all modified files
• Verify Prettier formatting passes on all modified files
• Open each table listing page and verify a divider appears before destructive actions in kebab menus
• Open each detail page and verify a divider appears before destructive actions in the Actions dropdown
• Verify no divider appears when the destructive action is the only menu item (e.g., user with only delete permission)
• Verify catalog page shows divider before "Remove" action

[jkilzi]

Clean, comprehensive refactor. The two-tier API is well-designed: the JSX compound component (ActionsDropdownList + Item) handles DropdownList usages, while the buildAllDropdownActions helper handles IAction[] arrays for ActionsColumn table rows. Both produce a consistent separator between regular and danger groups.

The mechanical nature of the change (same pattern applied to ~20 files) reduces per-file risk, and CI passing validates correctness.

Good — ImageExportCards action ordering. Moving delete to the end of the actions list (danger group) is the right UX change.

Note — child.type reference equality. ActionsDropdownList uses child.type === ActionsDropdownListItem to classify children. This is a valid React pattern but can theoretically fail in extreme HMR or module-isolation scenarios. Low production risk, but a brief JSDoc comment on the component explaining the classification convention would help future maintainers.

Nit — bundled label rename. "Remove" → "Delete catalog" in CatalogPage.tsx is a welcome clarity improvement, but it's bundled silently into a PR titled "Add divider before Delete". Worth calling out in the description so translators don't miss it.

Nit — ActionsDropdownListItem renders as a fragment. The isDanger prop is intentionally unused by the component itself (the parent reads it via child.props.isDanger). This is a valid React convention but unusual enough to warrant a comment for maintainers.

[bugs-buddy-jira-ai-issue-solver]

In comment, @jkilzi said:

Clean, comprehensive refactor. The two-tier API is well-designed: the JSX compound component (ActionsDropdownList + Item) handles DropdownList usages, while the buildAllDropdownActions helper handles IAction[] arrays for ActionsColumn table rows. Both produce a consistent separator between regular and danger groups.

The mechanical nature of the change (same pattern applied to ~20 files) reduces per-file risk, and CI passing validates correctness.

Good — ImageExportCards action ordering. Moving delete to the end of the actions list (danger group) is the right UX change.

Note — child.type reference equality. ActionsDropdownList uses child.type === ActionsDropdownListItem to classify children. This is a valid React pattern but can theoretically fail in extreme HMR or module-isolation scenarios. Low production risk, but a brief JSDoc comment on the component explaining the classification convention would help future maintainers.

Nit — bundled label rename. "Remove" → "Delete catalog" in CatalogPage.tsx is a welcome clarity improvement, but it's bundled silently into a PR titled "Add divider before Delete". Worth calling out in the description so translators don't miss it.

Nit — ActionsDropdownListItem renders as a fragment. The isDanger prop is intentionally unused by the component itself (the parent reads it via child.props.isDanger). This is a valid React convention but unusual enough to warrant a comment for maintainers.

Added JSDoc comments addressing both notes: (1) ActionsDropdownList now documents the child.type reference-equality classification convention for future maintainers, (2) ActionsDropdownListItem now explains that isDanger is intentionally read by the parent, not the component itself. The bundled label rename ("Remove" → "Delete catalog") is a PR description concern — acknowledged, but no code change needed.

Addressed in b6bb5ca.

[celdrake]

Needs re-approval after last commit adding JSDoc comments.

[bugs-buddy-jira-ai-issue-solver]

AI Session Costs

Session	Cost
Feedback #1	$1.16
Feedback #2	$0.81
Feedback #3	$0.80
Feedback #4	$1.04
Feedback #5	$0.52
Feedback #6	$0.38
Feedback #7	$0.89
Feedback #8	$0.60
Feedback #9	$0.71
Total	$6.91

[bugs-buddy-jira-ai-issue-solver]

In comment, @celdrake said:

Needs re-approval after last commit adding JSDoc comments.

I was unable to produce code changes to address this comment after multiple attempts.

[celdrake]

@bugs-buddy-jira-ai-issue-solver Ignore the following comment
This is a message for a human :)

[bugs-buddy-jira-ai-issue-solver]

In comment, @celdrake said:

@@bugs-buddy-jira-ai-issue-solver Ignore the following comment
This is a message for a human :)

I was unable to produce code changes to address this comment after multiple attempts.

[amir-yogev-gh]

@bugs-buddy-jira-ai-issue-solver Ignore the following comment
This is a message for a human :)

[bugs-buddy-jira-ai-issue-solver]

In comment, @amir-yogev-gh said:

@bugs-buddy-jira-ai-issue-solver Ignore the following comment
This is a message for a human :)

I was unable to produce code changes to address this comment after multiple attempts.