Skip to content

EDM-4146: Rename accessible to available in UI#703

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-4146-accessible-naming
Jun 29, 2026
Merged

EDM-4146: Rename accessible to available in UI#703
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-4146-accessible-naming

Conversation

@celdrake

@celdrake celdrake commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

We now refer to repositories "availability" rather than "accessibility".

This deviates from the API wording that still refers to "Accessibility", so in places like events or error messages there may be mixed wording.

Areas Affected

libs/ui-components/ (shared UI component library)

  • 5 files updated to replace “accessible/accessibility” terminology with “available/availability” for repository and resource synchronization UI status/text.

Summary

This PR updates UI terminology across the shared libs/ui-components/ library so repository/resource-synchronization “availability” is shown in place of “accessibility.” The change is limited to UI wording and does not modify API contracts, type definitions, or backend naming.

Files modified:

  1. libs/ui-components/src/components/Events/useEvents.ts — Updated i18n event reason titles for repository/resource-sync availability (e.g., REPOSITORY_ACCESSIBLE/REPOSITORY_INACCESSIBLE, RESOURCE_SYNC_ACCESSIBLE/RESOURCE_SYNC_INACCESSIBLE) to display “Available” / “Not available”.
  2. libs/ui-components/src/components/ImageBuilds/SourceImageValidation.tsx — Updated validation/loading/status labels to “Checking image availability”, “Available”, “Not available”.
  3. libs/ui-components/src/components/Repository/CreateRepository/CreateRepositoryForm.tsx — Updated “Validation suffix” helper text for HTTP repositories from “accessible” to “available”.
  4. libs/ui-components/src/components/form/RepositorySelect.tsx — Updated repository status dropdown mapping to “Available” / “Not available”.
  5. libs/ui-components/src/utils/status/repository.ts — Updated repository status label mappings/localization keys to “Available” / “Not available”.

Cross-Cutting Implications

Shared component impact: Because these are in the shared libs/ui-components/ library, the terminology is applied consistently anywhere both standalone and the OCP plugin consume this library.

Mixed terminology remains possible: The PR description notes the API still uses “Accessibility,” so some backend-driven labels (e.g., event naming/error text) may still show “Accessibility” until the API wording is updated.

Not affected: No changes to Go auth proxy, container builds, packaging, E2E tests, or CI/workflow configuration.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 6cbd668e-0c29-4e9d-a8d6-ee0ed19be88a

📥 Commits

Reviewing files that changed from the base of the PR and between 8e2409d and 0d5ec29.

⛔ Files ignored due to path filters (1)
  • libs/i18n/locales/en/translation.json is excluded by !libs/i18n/locales/en/translation.json
📒 Files selected for processing (5)
  • libs/ui-components/src/components/Events/useEvents.ts
  • libs/ui-components/src/components/ImageBuilds/SourceImageValidation.tsx
  • libs/ui-components/src/components/Repository/CreateRepository/CreateRepositoryForm.tsx
  • libs/ui-components/src/components/form/RepositorySelect.tsx
  • libs/ui-components/src/utils/status/repository.ts

Walkthrough

Renames user-facing repository, event, image validation, and create-repository status text from “accessible/inaccessible/accessibility” to “available/not available/availability”.

Changes

UI Label Rename: accessible → available

Layer / File(s) Summary
Repository status labels and select text
libs/ui-components/src/utils/status/repository.ts, libs/ui-components/src/components/form/RepositorySelect.tsx
repositoryStatusLabels and getRepositoryItems now use Available / Not available translation keys for repository accessibility states.
Event reason titles, image validation, and form helper text
libs/ui-components/src/components/Events/useEvents.ts, libs/ui-components/src/components/ImageBuilds/SourceImageValidation.tsx, libs/ui-components/src/components/Repository/CreateRepository/CreateRepositoryForm.tsx
getEventReasonTitles updates repository and resource-sync reason titles, SourceImageValidation changes its loading and status text, and the CreateRepository validation suffix helper text now says “available”.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • flightctl/flightctl-ui#646: Modifies the same getEventReasonTitles area in useEvents.ts and adds related event-reason translation keys.

Suggested labels

ui-components, i18n

Suggested reviewers

  • rawagner

Poem

"Accessible" took a bow and left the scene,
"Available" arrived, crisp and clean.
Five small updates, wording in tune,
No logic shifted, just a gentler rune.
The UI speaks with one clear voice tonight ✨

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Unchecked-Errors ⚠️ Warning proxy/bridge/handler.go, proxy/auth/auth.go, and proxy/bridge/terminal.go ignore error returns with _ =/, _ := and no justifying comments. Handle or log those errors, or add explicit comments where ignoring them is intentionally safe and proven.
I18n-Compliance ⚠️ Warning CreateRepositoryForm.tsx has a user-visible ModalHeader title hardcoded as 'Change repository type?' instead of being wrapped in t(). Wrap the ModalHeader title in t() (or a translated constant) so the string is localized.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the PR’s main UI wording change from accessible to available.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed No hardcoded secrets found; touched changes only rename UI labels and status text, with no API keys, tokens, passwords, PEM blocks, or embedded-credential URLs.
No-Weak-Crypto ✅ Passed Touched files only rename UI/status strings; scans found no MD5/SHA1/DES/RC4/ECB, crypto APIs, or secret comparisons.
No-Injection-Vectors ✅ Passed Touched files only update UI wording; searches found no eval/exec, dangerouslySetInnerHTML, shell commands, or unsafe yaml usage.
Container-Privileges ✅ Passed PASS: Changed files are UI-only; no manifest/container privilege flags were introduced.
No-Sensitive-Data-In-Logs ✅ Passed Scanned all changed files; no console/logger calls or other logging sinks were added, and no sensitive fields are emitted to logs.
Resource-Leaks ✅ Passed PR touches only ui-components; no proxy/ Go files changed, so the resource-leak check is not applicable.
Ai-Attribution ✅ Passed HEAD includes Made-with: Cursor, which satisfies AI attribution, and no Co-Authored-By trailer is present.
Generated-Files-Not-Hand-Edited ✅ Passed No direct edits to generated model files; the only generated-path diff is translation.json, and it matches the updated UI strings, consistent with i18n regeneration.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jkilzi jkilzi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent, clean rename throughout. All affected surfaces — translation.json, useEvents.ts, SourceImageValidation.tsx, RepositorySelect.tsx, CreateRepositoryForm.tsx, and repository.ts — are updated in sync.

Watch — merge conflict with #692: both PRs touch the same lines in RepositorySelect.tsx (getRepositoryItems). Merge #692 first, then rebase this PR.

@celdrake celdrake force-pushed the EDM-4146-accessible-naming branch from 8e2409d to 0d5ec29 Compare June 29, 2026 06:26
@celdrake celdrake merged commit 3257707 into flightctl:main Jun 29, 2026
10 checks passed
@celdrake celdrake deleted the EDM-4146-accessible-naming branch June 29, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants