EDM-4152: Make all form alerts full width#696
Conversation
Made-with: Cursor
WalkthroughThis PR introduces ChangesAlert Component Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@libs/ui-components/src/components/form/FlightCtlForm.tsx`:
- Around line 52-55: FlightCtlFormAlert currently concatenates className with a
literal space causing a trailing space when className is falsy; in the
FlightCtlFormAlert component update the className construction so the extra
space is only added when a non-empty className exists (e.g., join base
"fctl-form-alert" with the incoming className conditionally or build the string
by appending `" " + className` only when className is truthy) and pass that into
the Alert component's className prop to avoid the cosmetic trailing space.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 80382d93-0462-4c69-8ff3-07f0a58c0a34
📒 Files selected for processing (15)
libs/ui-components/src/components/Catalog/EditWizard/steps/UpdateStep.tsxlibs/ui-components/src/components/Catalog/InstallWizard/steps/AppConfigStep.tsxlibs/ui-components/src/components/Catalog/InstallWizard/steps/ReviewStep.tsxlibs/ui-components/src/components/Catalog/InstallWizard/steps/SelectTargetStep.tsxlibs/ui-components/src/components/Catalog/InstallWizard/steps/SpecificationsStep.tsxlibs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationTemplates.tsxlibs/ui-components/src/components/Device/EditDeviceWizard/steps/ConfigurationTemplates.tsxlibs/ui-components/src/components/Device/EditDeviceWizard/steps/DeviceTemplateStep.tsxlibs/ui-components/src/components/Device/EditDeviceWizard/steps/DeviceUpdateStep.tsxlibs/ui-components/src/components/Fleet/CreateFleet/steps/DeviceLabelSelector.tsxlibs/ui-components/src/components/Fleet/CreateFleet/steps/UpdatePolicyStep.tsxlibs/ui-components/src/components/Fleet/CreateFleet/steps/UpdateStepRolloutPolicy.tsxlibs/ui-components/src/components/ImageBuilds/CreateImageBuildWizard/steps/OutputImageStep.tsxlibs/ui-components/src/components/form/FlightCtlForm.csslibs/ui-components/src/components/form/FlightCtlForm.tsx
|
We're clarifying exact requirements with UX. |
Alerts within forms were not full-width, now we can use
FlightCtlFormAlertfor that purpose.Before:
After:
