EDM-4156: Add divider to menu footer

[celdrake]

Added divider both to the "Create catalog" and "Create repository"

Summary

Adds visual dividers to the footer action areas of shared select/menu components, improving separation between selectable options and “create” actions.

Areas Affected

libs/ui-components/

• libs/ui-components/src/components/form/FormSelect.tsx: When addAction is present, inserts a Divider above the menu footer/button (e.g., “Create catalog”).
• libs/ui-components/src/components/form/RepositorySelect.tsx: Inserts a Divider above the “Create repository” menu footer/button.

Cross-Cutting Implications

Changes are isolated to the shared UI components library; no platform-specific app, auth proxy, packaging/container build, E2E tests, or CI configuration changes were made. The updated menu footer rendering applies anywhere these shared select components are used (e.g., across standalone and any other consumers of libs/ui-components).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: d1c4d45a-b0a4-468a-8757-995b0eba3173

📥 Commits

Reviewing files that changed from the base of the PR and between c073ce8 and 18df8aa.

📒 Files selected for processing (2)

• libs/ui-components/src/components/form/FormSelect.tsx
• libs/ui-components/src/components/form/RepositorySelect.tsx

---

Walkthrough

Two select components now render PatternFly Divider elements above their footer actions. FormSelect applies this to addAction, and RepositorySelect applies it to the “Create repository” action.

Changes

Select Menu Divider Separators

Layer / File(s)	Summary
FormSelect menu footer divider libs/ui-components/src/components/form/FormSelect.tsx	Imports Divider from PatternFly and wraps the optional addAction footer in a fragment that inserts a divider above MenuFooter.
RepositorySelect menu footer divider libs/ui-components/src/components/form/RepositorySelect.tsx	Imports Divider and wraps the canCreateRepo footer in a fragment that inserts a divider above the existing MenuFooter and create button.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

ui-components

Poem

A line appears, crisp and bright,
Between the menu and the action below;
Two selects now feel just right,
With tidy spacing in their glow ✨

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Unchecked-Errors	⚠️ Warning	proxy/bridge/terminal.go and proxy/bridge/handler.go ignore returned errors (WriteControl, Body.Close, json.Marshal) without comments or handling.	Handle these errors or add brief comments explaining why each ignore is safe (e.g. best-effort close), as required by the check.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding a divider to menu footer actions in the select components.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	Scanned both changed files; only UI literals/imports were added, with no hardcoded secrets, credential URLs, or secret-like string assignments.
No-Weak-Crypto	✅ Passed	Touched files only add Divider/UI footer changes; no weak algorithms, custom crypto, or secret comparisons appear in the modified code.
No-Injection-Vectors	✅ Passed	No eval/exec/dangerouslySetInnerHTML/yaml.load sinks were added; the changes only wrap existing React footer buttons with Divider/Fragment.
Container-Privileges	✅ Passed	PR only changes two TSX UI files; no container/K8s manifests or privilege settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only add Divider/MenuFooter UI; no logging calls or sensitive-data handling appear in the modified code.
Resource-Leaks	✅ Passed	PR only changes two React/TSX UI components; no Go files in proxy/ are part of this change, so the resource-leak check is not applicable.
Ai-Attribution	✅ Passed	HEAD includes Made-with: Cursor in the commit trailer, and no Co-Authored-By AI trailer is present.
Generated-Files-Not-Hand-Edited	✅ Passed	No direct edits in libs/types/** or libs/types/imagebuilder/**; the translation.json change matches source-string updates and appears regenerated.
I18n-Compliance	✅ Passed	PASS: The added footer text is supplied via t('Create catalog')/t('Create repository'); no new raw user-visible strings or variable t() keys appear in the changed TSX.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

_{Comment @coderabbitai help to get the list of available commands.}

[jkilzi]

Simple, correct visual improvement.

Watch — merge conflict with #692: #692 removes the MenuFooter from RepositorySelect.tsx entirely and moves the add action to FormSelect via the addAction prop. If #692 merges first, the RepositorySelect.tsx hunk in this PR becomes obsolete — only the FormSelect.tsx hunk stays relevant. Rebase after #692 and drop the RepositorySelect.tsx change.