general improvements#2
Open
g1-1-1 wants to merge 3 commits into
Open
Conversation
- refactor error handling to use `result` types - use proper string concatenation methods for efficiency - make API base URL configurable - update struct names to follow snake_case convention - add inline comments and documentation for clarity
- separate token validation and object initialization logic into distinct functions - replace unwrap and panic with proper error handling using `result` and the `?` operator - remove unnecessary string formatting in API requests for better performance - provide more informative error messages for token validation and network errors
- extracts common functionality into helper methods - uses `result` for error handling - more constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is untested, please test this and make sure it works properly.