fix(metrics): reset gauge vectors on recalculation to clear stale metrics - #1586
Draft
Neha-Nimsatkar wants to merge 1 commit into
Draft
fix(metrics): reset gauge vectors on recalculation to clear stale metrics#1586Neha-Nimsatkar wants to merge 1 commit into
Neha-Nimsatkar wants to merge 1 commit into
Conversation
…rics Signed-off-by: Neha-Nimsatkar <1492neha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(metrics): reset gauge vectors on recalculation to clear stale metrics
In
backend/pkg/metrics/metrics.go,appInstancePerChannelGaugeMetricandfailedUpdatesGaugeMetricare updated viaWithLabelValues(...).Set(...)whenevercalculateMetrics()executes.When an instance upgrades, gets deregistered, or an application/version combination is no longer returned by the database queries (
GetAppInstancesPerChannelMetricsorGetFailedUpdatesMetrics), the Prometheus collector retains the previous label values indefinitely in memory.This PR adds
.Reset()calls on bothGaugeVeccollectors before setting fresh values so that stale time-series label combinations are properly cleared on each recalculation cycle.How to use
Reviewers can inspect
calculateMetrics()inbackend/pkg/metrics/metrics.goto verify thatappInstancePerChannelGaugeMetric.Reset()andfailedUpdatesGaugeMetric.Reset()are invoked prior to metric iteration.Testing done
go fmt ./pkg/metrics/...to ensure standard Go formatting.cd backend go build ./pkg/metrics/...