Skip to content

fix(api): validate blacklist channel arch on package update - #1584

Open
tagadearpit wants to merge 1 commit into
flatcar:mainfrom
tagadearpit:fix/validate-blacklist-channel-arch
Open

fix(api): validate blacklist channel arch on package update#1584
tagadearpit wants to merge 1 commit into
flatcar:mainfrom
tagadearpit:fix/validate-blacklist-channel-arch

Conversation

@tagadearpit

Copy link
Copy Markdown

Summary

Package updates did not validate the architecture of newly blacklisted channels. As a result, an amd64 package could be updated with an aarch64 channel in its blacklist, even though package creation already rejected the same mismatch.

This change calls the existing checkMatchingArch validation from updatePackageBlacklistedChannels before blacklist entries are inserted and adds regression coverage for the update path.

Tracking issue: flatcar/nebraska#1596

Tests

The following checks pass:

NEBRASKA_DB_URL=postgres://postgres:nebraska@127.0.0.1:5432/nebraska_tests?sslmode=disable&connect_timeout=10 go test ./pkg/api/... -run '^TestUpdatePackageArchMismatch$' -count=1 -v
NEBRASKA_DB_URL=postgres://postgres:nebraska@127.0.0.1:5432/nebraska_tests?sslmode=disable&connect_timeout=10 go test -p 1 ./pkg/api/... -count=1
go vet ./pkg/api/...

@tagadearpit
tagadearpit requested a review from a team as a code owner August 14, 2026 13:02
Signed-off-by: tagadearpit <1.43588157e+08+tagadearpit@users.noreply.github.com>
@tagadearpit
tagadearpit force-pushed the fix/validate-blacklist-channel-arch branch from aa03e1c to 0f07d67 Compare August 14, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant