test(metrics): add unit tests for getMetricsRefreshInterval - #1583
Open
Neha-Nimsatkar wants to merge 1 commit into
Open
test(metrics): add unit tests for getMetricsRefreshInterval#1583Neha-Nimsatkar wants to merge 1 commit into
Neha-Nimsatkar wants to merge 1 commit into
Conversation
Signed-off-by: Neha-Nimsatkar <1492neha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(metrics): add unit tests for getMetricsRefreshInterval
This PR adds unit tests for
getMetricsRefreshInterval()in thebackend/pkg/metricspackage. Currently, the metrics package does not have test coverage for environment variable parsing.The tests cover all parsing scenarios and fallback behaviors:
NEBRASKA_METRICS_UPDATE_INTERVALis unset30s,2m)How to use
Reviewers can validate this change by running the Go test suite inside the
backendpackage.Testing done
go fmt ./pkg/metrics/...