Fix group timeline refetch on group change - #1573
Open
nyxsky404 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sumit Kumar <sumit76231@gmail.com>
nyxsky404
force-pushed
the
codex/fix-group-timeline-refetch
branch
from
August 14, 2026 21:03
427735c to
c467b57
Compare
Author
|
@ervcz this pr is ready for review. Please let me know if any scope or test changes would help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The group timeline effects read
props.group,group.application_id,group.id,duration.queryValue, and the chart store, but only depended on the duration object and disabledreact-hooks/exhaustive-deps. When the selected group changed with the same duration, the effects did not run, so the components continued showing the previous group's timeline data.StatusCountTimelinealso lacked cancellation handling, andVersionCountTimelineonly guarded part of the async update path.Testing
npx vitest run --silent=true src/components/Groups/GroupCharts/GroupTimelineRefetch.spec.tsxnpx eslint src/components/Groups/GroupCharts/VersionCountTimeline.tsx src/components/Groups/GroupCharts/StatusCountTimeline.tsx src/components/Groups/GroupCharts/GroupTimelineRefetch.spec.tsxnpx tsc -b --pretty falsenpm testnpm run buildScreenshots
Not applicable. This is a data-fetch lifecycle fix with no intentional visual changes; the behavior is covered by regression tests.
Fixes #1572