fix(metrics): scope failed_updates to last day and add group label - #1568
Draft
Harsh63870 wants to merge 1 commit into
Draft
fix(metrics): scope failed_updates to last day and add group label#1568Harsh63870 wants to merge 1 commit into
Harsh63870 wants to merge 1 commit into
Conversation
Filter nebraska_failed_updates to the last day, break it down by group, and reset the gauge before refresh so operators can alert on recent per-group failure rates. Fixes flatcar#1567. Signed-off-by: Harsh63870 <harshvardhanpandey372@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1567.
nebraska_failed_updatespreviously counted every failed update event ever recorded and only exposed anapplicationlabel. That made it hard to use for current rollout health.This PR:
grouplabel (viainstance_application→groups; missing group →unknown)Test plan
cd backend && go test ./pkg/api/ -run TestGetFailedUpdatesMetrics/metricsand confirm series look likenebraska_failed_updates{application="...",group="..."}Notes
Adding the
grouplabel changes the metric’s label set. Existing Grafana queries that only useapplicationcan keep working withsum by (application) (nebraska_failed_updates).